On Wed, 12 Aug 2015, Thierry Reding <thierry.reding@xxxxxxxxx> wrote: > From: Thierry Reding <treding@xxxxxxxxxx> > > The enhanced framing capability was added in DisplayPort 1.1, so any > code dealing with it needs to be protected accordingly. > > Signed-off-by: Thierry Reding <treding@xxxxxxxxxx> > --- > drivers/gpu/drm/drm_dp_helper.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c > index 45701c650a5d..dcfd6898aebe 100644 > --- a/drivers/gpu/drm/drm_dp_helper.c > +++ b/drivers/gpu/drm/drm_dp_helper.c > @@ -308,8 +308,9 @@ int drm_dp_link_probe(struct drm_dp_aux *aux, struct drm_dp_link *link) > link->rate = drm_dp_bw_code_to_link_rate(values[1]); > link->num_lanes = values[2] & DP_MAX_LANE_COUNT_MASK; > > - if (values[2] & DP_ENHANCED_FRAME_CAP) > - link->capabilities |= DP_LINK_CAP_ENHANCED_FRAMING; > + if (link->revision >= 0x11) > + if (values[2] & DP_ENHANCED_FRAME_CAP) > + link->capabilities |= DP_LINK_CAP_ENHANCED_FRAMING; Oh, and perhaps the conditions should be encoded into helpers (of helpers!) in drm_dp_helper.h. There's already drm_dp_enhanced_frame_cap that checks DPCD REV. BR, Jani. > > if (link->revision >= 0x12) > if (values[2] & DP_TPS3_SUPPORTED) > -- > 2.4.5 > > _______________________________________________ > dri-devel mailing list > dri-devel@xxxxxxxxxxxxxxxxxxxxx > http://lists.freedesktop.org/mailman/listinfo/dri-devel -- Jani Nikula, Intel Open Source Technology Center _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
