Hi Jingoo,
在 2015/8/21 16:20, Jingoo Han 写道:
On 2015. 8. 19., at PM 11:48, Yakir Yang <ykk@xxxxxxxxxxxxxx> wrote:
.....
.../bindings/video/analogix_dp-rockchip.txt | 83 ++
.../devicetree/bindings/video/exynos_dp.txt | 51 +-
arch/arm/boot/dts/exynos5250-arndale.dts | 10 +-
arch/arm/boot/dts/exynos5250-smdk5250.dts | 10 +-
arch/arm/boot/dts/exynos5250-snow.dts | 12 +-
arch/arm/boot/dts/exynos5250-spring.dts | 12 +-
arch/arm/boot/dts/exynos5420-peach-pit.dts | 12 +-
arch/arm/boot/dts/exynos5420-smdk5420.dts | 10 +-
arch/arm/boot/dts/exynos5800-peach-pi.dts | 12 +-
drivers/gpu/drm/bridge/Kconfig | 5 +
drivers/gpu/drm/bridge/Makefile | 1 +
drivers/gpu/drm/bridge/analogix_dp_core.c | 1382 +++++++++++++++++++
drivers/gpu/drm/bridge/analogix_dp_core.h | 286 ++++
drivers/gpu/drm/bridge/analogix_dp_reg.c | 1294 ++++++++++++++++++
.../exynos_dp_reg.h => bridge/analogix_dp_reg.h} | 270 ++--
drivers/gpu/drm/exynos/Kconfig | 5 +-
drivers/gpu/drm/exynos/Makefile | 2 +-
drivers/gpu/drm/exynos/analogix_dp-exynos.c | 347 +++++
Would you change this file name to "exynos_dp.c"?
Sorry, I don't think so ;(
I think IP_name+Soc_name would be better in this re-use case.
So? Is there the naming rule such as "IP_name+SoC_name"?
Beside
I see
there are lots of driver named with this format in kernel, such as
dw_hdmi & dw_mmc
Please look at other dw cases. For example, look at dw_pcie.
drivers/pci/host/ pcie-designware.c pci-spear13xx.c pci-exynos.c
In this case, pci-spear13xx.c and pci-exynos.c do not use "IP_name+SoC_name", even though these are dw IPs.
Also, naming consistency is more important. Now, Exynos DRM files are using "exynos_drm_" prefix.
drivers/gpu/drm/exynos/ exynos_drm_buf.c exynos_drm_core.c ....
However, "analogix_dp-exynos.c" looks very inconsistent.
If there is no strict naming rule, please use "exynos_dp.c" or "exynos_drm_dp.c".
Best regards, Jingoo Han
(cr) (chromeos-3.14) yakir@server
~/trunk/src/third_party/kernel/v3.14 $ ls
drivers/gpu/drm/imx/
dw_hdmi-imx.c imx-drm.h
imx-tve.c ipuv3-plane.c Kconfig parallel-display.c
(cr) (chromeos-3.14) yakir@server
~/trunk/src/third_party/kernel/v3.14 $ ls
drivers/mmc/host/dw_mmc*
drivers/mmc/host/dw_mmc.c drivers/mmc/host/dw_mmc.h
drivers/mmc/host/dw_mmc-pci.c drivers/mmc/host/dw_mmc-pltfm.h
drivers/mmc/host/dw_mmc-exynos.c drivers/mmc/host/dw_mmc-k3.c
drivers/mmc/host/dw_mmc-pltfm.c drivers/mmc/host/dw_mmc-rockchip.c
Thanks,
- Yakir
Best regards,
Jingoo Han
drivers/gpu/drm/exynos/exynos_dp_core.c | 1416 --------------------
drivers/gpu/drm/exynos/exynos_dp_core.h | 282 ----
drivers/gpu/drm/exynos/exynos_dp_reg.c | 1263 -----------------
drivers/gpu/drm/rockchip/Kconfig | 9 +
drivers/gpu/drm/rockchip/Makefile | 1 +
drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 390 ++++++
drivers/phy/Kconfig | 7 +
drivers/phy/Makefile | 1 +
drivers/phy/phy-rockchip-dp.c | 185 +++
include/drm/bridge/analogix_dp.h | 40 +
30 files changed, 4325 insertions(+), 3172 deletions(-)
create mode 100644 Documentation/devicetree/bindings/drm/bridge/analogix_dp.txt
create mode 100644 Documentation/devicetree/bindings/phy/rockchip-dp-phy.txt
create mode 100644 Documentation/devicetree/bindings/video/analogix_dp-rockchip.txt
create mode 100644 drivers/gpu/drm/bridge/analogix_dp_core.c
create mode 100644 drivers/gpu/drm/bridge/analogix_dp_core.h
create mode 100644 drivers/gpu/drm/bridge/analogix_dp_reg.c
rename drivers/gpu/drm/{exynos/exynos_dp_reg.h => bridge/analogix_dp_reg.h} (62%)
create mode 100644 drivers/gpu/drm/exynos/analogix_dp-exynos.c
delete mode 100644 drivers/gpu/drm/exynos/exynos_dp_core.c
delete mode 100644 drivers/gpu/drm/exynos/exynos_dp_core.h
delete mode 100644 drivers/gpu/drm/exynos/exynos_dp_reg.c
create mode 100644 drivers/gpu/drm/rockchip/analogix_dp-rockchip.c
create mode 100644 drivers/phy/phy-rockchip-dp.c
create mode 100644 include/drm/bridge/analogix_dp.h
--
1.9.1
|
