Re: [PATCH 3/7] drm/vmwgfx: Initial DX support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 08/21/2015 02:19 PM, Emil Velikov wrote:
> Hi Thomas,
>
> On 13 August 2015 at 06:49, Thomas Hellstrom <thellstrom@xxxxxxxxxx> wrote:
> [snip]
>> --- a/include/uapi/drm/vmwgfx_drm.h
>> +++ b/include/uapi/drm/vmwgfx_drm.h
>> @@ -826,7 +830,6 @@ struct drm_vmw_update_layout_arg {
>>  enum drm_vmw_shader_type {
>>         drm_vmw_shader_type_vs = 0,
>>         drm_vmw_shader_type_ps,
>> -       drm_vmw_shader_type_gs
>>  };
>>
> Won't this hunk cause API/ABI breakage ? I guess one could get away if
> no users ever relied upon it.

Hi, Emil,

You're right. However, the kernel driver (other than in-house
development versions) should never have supported the gs shader type
anyway, so we don't break anything existing. With the current version,
geometry shaders are created using the GPU command stream.

Thanks,
Thomas



>
> Thanks
> Emil
> _______________________________________________
> dri-devel mailing list
> dri-devel@xxxxxxxxxxxxxxxxxxxxx
> http://lists.freedesktop.org/mailman/listinfo/dri-devel

_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux