On Thu, Aug 20, 2015 at 5:13 PM, Mark Brown <broonie@xxxxxxxxxx> wrote: > On Thu, Aug 20, 2015 at 04:09:21PM -0400, Alex Deucher wrote: >> From: Maruthi Srinivas Bayyavarapu <Maruthi.Bayyavarapu@xxxxxxx> >> >> ACP IP block consists of dedicated DMA and I2S blocks. The PCM driver >> provides the DMA and CPU DAI components to ALSA core. >> >> v2: squash in Kconfig fix >> v3: squash additional commits, convert to mfd, drop rt286 changes >> v4: squash in naming fixes > > To repeat what I said last time: > > | Please follow the patch submission process in SubmittingPatches: put any > | versioning in the subject line inside the [] and put noise like inter > | version changelogs after the ---. I addressed this in my coverletter. Some subsystems prefer to retain that information. If you'd prefer to not have them in the audio patch I will remove them. > >> +/* >> + * AMD ALSA SoC PCM Driver >> + * >> + * Copyright 2014-2015 Advanced Micro Devices, Inc. >> + * >> + * Permission is hereby granted, free of charge, to any person obtaining a >> + * copy of this software and associated documentation files (the "Software"), >> + * to deal in the Software without restriction, including without limitation >> + * the rights to use, copy, modify, merge, publish, distribute, sublicense, >> + * and/or sell copies of the Software, and to permit persons to whom the >> + * Software is furnished to do so, subject to the following conditions: >> + * >> + * The above copyright notice and this permission notice shall be included in >> + * all copies or substantial portions of the Software. >> + * >> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR >> + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, >> + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL >> + * THE COPYRIGHT HOLDER(S) OR AUTHOR(S) BE LIABLE FOR ANY CLAIM, DAMAGES OR >> + * OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, >> + * ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR >> + * OTHER DEALINGS IN THE SOFTWARE. > > I also remain very concerned about this non-GPL license you are using. > Please do not ignore review comments like this :( I mentioned this in the cover letter as well. Most if not all of the drm drivers are licensed the same way. IANAL, but I am not aware of any concerns about them. Alex _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
