On Thu, Jul 09, 2015 at 11:32:44PM +0200, Daniel Vetter wrote: > It doesn't protect anything at all. fbdev helper state is all > protected by modeset locks, and nouveau bo state is taken care of by > ttm. There's also nothing else grabbing struct_mutex that might need > to coordinate with this code. Also this is driver load code, no one > can get at the device yet anyway so locking is fairly futile. > There's also no drm_gem_object_unreference that would now suddenly > need the _unlocked variant. > > Cc: Ben Skeggs <bskeggs@xxxxxxxxxx> > Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxxx> > --- > drivers/gpu/drm/nouveau/nouveau_fbcon.c | 11 +++-------- > 1 file changed, 3 insertions(+), 8 deletions(-) Reviewed-by: Thierry Reding <treding@xxxxxxxxxx>
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
