Re: [PATCH 3/3] modeprint: cleanup, remove compile warnings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 7 August 2015 at 08:37, Tapani Pälli <tapani.palli@xxxxxxxxx> wrote:
> Signed-off-by: Tapani Pälli <tapani.palli@xxxxxxxxx>
> ---
>  tests/modeprint/modeprint.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/tests/modeprint/modeprint.c b/tests/modeprint/modeprint.c
> index e6c6553..5e953f7 100644
> --- a/tests/modeprint/modeprint.c
> +++ b/tests/modeprint/modeprint.c
> @@ -61,6 +61,7 @@ static const char* getConnectionText(drmModeConnection conn)
>                 return "connected";
>         case DRM_MODE_DISCONNECTED:
>                 return "disconnected";
> +       case DRM_MODE_UNKNOWNCONNECTION:
>         default:
>                 return "unknown";
>         }
> @@ -124,9 +125,6 @@ static int printProperty(int fd, drmModeResPtr res, drmModePropertyPtr props, ui
>                 }
>
>         } else {
> -               if (!strncmp(props->name, "DPMS", 4))
> -                       ;
> -
I've never bothered checking if this hunk was useful at some point. If
you had can you add a line in the commit log.

Regardless, the series is
Reviewed-by: Emil Velikov <emil.l.velikov@xxxxxxxxx>

Thanks for sticking with my suggestion and killing off the c_plusplus fossil.
-Emil
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux