On Thu, Aug 06, 2015 at 03:23:00AM +0300, Laurent Pinchart wrote: > The plane reset handler frees the plane state and allocates a new > default state, but when doing so attempt to free the plane state using > the base plane state pointer instead of casting it to the > driver-specific state object that has been allocated. Fix it by using > the rcar_du_plane_atomic_destroy_state() function to destroy the plane > state instead of duplicating the code. > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx> > --- > drivers/gpu/drm/rcar-du/rcar_du_plane.c | 45 ++++++++++++++++----------------- > 1 file changed, 22 insertions(+), 23 deletions(-) > > Should the DRM core free the atomic state before calling the reset operation ? > That would simplify drivers. The core can't do that because drivers might have subclassed the state. Reviewed-by: Thierry Reding <treding@xxxxxxxxxx>
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
