Re: [PATCH] libdrm/amdgpu: Fixed drm.h include.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jul 22, 2015 at 1:19 PM, Michel Dänzer <michel@xxxxxxxxxxx> wrote:
> On 17.07.2015 22:33, Alexandr Akulich wrote:
>> As I see, this is not a kernel header, but a local (belongs to libdrm) one.
>> (Otherwise, I would like you to point me on such file at, say,
>> https://github.com/torvalds/linux/tree/master/include/drm)
>
> https://github.com/torvalds/linux/blob/master/include/uapi/drm/amdgpu_drm.h
>
>
>> At files drm_sarea.h, mga_drm.h, qxl_drm.h, radeon_drm.h and via_drm.h we have
>>
>> #include "drm.h"
>>
>> At the same time, at i915_drm.h and tegra_drm.h. we have
>>
>> #include <drm.h>
>>
>> I'm pretty sure that the first case is correct, because drm.h is
>> always would be local file (in the same directory), related to
>> amdgpu_drm.h, and that is why local include "drm.h" would be always
>> valid.
>
> Makes sense to me, the patch is
>
> Reviewed-by: Michel Dänzer <michel.daenzer@xxxxxxx>
Thanks! I have no write access to this fd.o repository. Can you apply it please?
>
>> This fixes libdrm build with amdgpu support on bare system for me.
>
> FWIW though, that's because you're dropping the drm/ prefix, not because
> you're changing from <> to "".
I know :-). Compiler would "fallback" from <> to "", if it can't find
a header in passed include directories.
>
> --
> Earthling Michel Dänzer               |               http://www.amd.com
> Libre software enthusiast             |             Mesa and X developer
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux