On Mon, Jul 20, 2015 at 01:38:46PM +0100, Chris Wilson wrote: > On Mon, Jul 20, 2015 at 05:59:29PM +0530, Sudip Mukherjee wrote: > > We were dereferencing dev first and then checking if it is NULL. Lets > > check for NULL first and then dereference. > > The code is bonkers. Testing for a lack of a correctly constructed > debugfs seq_file inside the debugfs seq_file callback is inane. I missed seeing before sending this patch that there are some more places where this has been done. Then are you suggesting to remove the test? regards sudip _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
