Re: [PATCH v2] drm: add a drm_atomic_helper_plane_check_update

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Op 13-07-15 om 13:50 schreef John Hunter:
> From: Zhao Junwang <zhjwpku@xxxxxxxxx>
>
> This is the equivalent helper to drm_plane_helper_check_update
> for legacy drivers, but using atomic state to check things.
>
> Motivated by the atomic conversion of the bochs driver.
>
> v2: according to Daniel's comment
>     -polish the kerneldoc comment to match the signatures
>     -crtc->mode is legacy state, we need to look at crtc_state
>      instead
>
>     according to Maarten's comment
>     -there is no need for can_update_disabled in the atomic world,
>      so, we can delete that parameter
>
> v3: according to Daniel's comment
>     -this function call can't fail, add a WARN_ON
>     -use drm_atomic_get_existing_crtc_state
>
>     according to Maarten's comment
>     -kill off the plane parameter and rename state to plane_state
>     -do not handling NULL, i.e. no need to check plane_state in
>      atomic.
>
> Cc: Maarten Lankhorst <maarten.lankhorst@xxxxxxxxxxxxxxx>
> Cc: Daniel Vetter <daniel.vetter@xxxxxxxx>
> Signed-off-by: Zhao Junwang <zhjwpku@xxxxxxxxx>

Reviewed-by: Maarten Lankhorst <maarten.lankhorst@xxxxxxxxxxxxxxx>

_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux