On 07/13/2015 01:37 PM, Daniel Vetter wrote:
On Mon, Jul 13, 2015 at 12:07:56PM +0530, Archit Taneja wrote:
DRM drivers using drm_fb_helpers still call some fbdev core functions.
This makes the driver depend on CONFIG_FB, resulting in complicated
Kconfig options, and preventing us from creating a top level drm config
option to enable/disable FBDEV emulation.
Create new drm_fb_helper functions that replace these fbdev functions.
In most cases, the new helper funcs simply wrap around the original fbdev
functions. For a few (like framebufer_alloc), we actually do some work
that is currently redundant across multiple drivers.
With these patches, the drivers don't call any fbdev functions directly.
They are now called through functions in drm_fb_helper.c. We will later
create a fbdev emulation config option to stub out the fb helpers.
The only exception is vmwgfx driver. This doesn't use drm_fb_helper. It
creates a fb device how a driver in drivers/video/fbdev would. Maybe this
needs to be converted to use drm_fb_helpers.
For more info, have a look at the threads:
http://lists.freedesktop.org/archives/dri-devel/2015-March/078729.html
http://lists.freedesktop.org/archives/dri-devel/2015-March/078975.html
I think overall this looks really nice. I quickly fired this up on an i915
machine and it worked, so I pulled it all into topic/drm-misc (which is in
linux-next) to give this the testing it needs. I'll probably do a separate
topic branch for the pull request to Dave with the final patches. My plan
would be to make one overall pull for step 1 plus the first patch of step
2. Then everything else could go in through driver maintainers like usual
I think.
Okay. That sounds good to me too. I'll fix up the comments and the
warnings thrown by the kbuild bot.
There was an initial Kconfig clean up patch set 'drm/misc: Kconfig
cleanup' that will make the remainder steps easier to pull. Could we try
to get that in too?
Archit
Cheers, Daniel
Archit Taneja (25):
drm/fb_helper: Add drm_fb_helper functions to manage fb_info creation
drm/fb_helper: Create a wrapper for unlink_framebuffer
drm/fb_helper: Create wrappers for fb_sys_read/write funcs
drm/fb_helper: Create wrappers for blit, copyarea and fillrect funcs
drm/fb_helper: Create a wrapper for fb_set_suspend
drm/fb_helper: Create a wrapper for remove_conflicting_framebuffers
drm/cirrus: Use new drm_fb_helper functions
drm/rockchip: Use new drm_fb_helper functions
drm/armada: Use new drm_fb_helper functions
drm/ast: Use new drm_fb_helper functions
drm/omap: Use new drm_fb_helper functions
drm/tegra: Use new drm_fb_helper functions
drm/msm: Use new drm_fb_helper functions
drm/exynos: Use new drm_fb_helper functions
drm/gma500: Use new drm_fb_helper functions
drm/mgag200: Use new drm_fb_helper functions
drm/radeon: Use new drm_fb_helper functions
drm/qxl: Use new drm_fb_helper functions
drm/i915: Use new drm_fb_helper functions
drm/nouveau: Use new drm_fb_helper functions
drm/udl: Use new drm_fb_helper functions
drm/boschs: Use new drm_fb_helper functions
drm/amdgpu: Use new drm_fb_helper functions
drm/virtio: Use new drm_fb_helper functions
drm/fb_cma_helper: Use new drm_fb_helper functions
drivers/gpu/drm/Kconfig | 7 ++
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 4 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c | 43 +++-----
drivers/gpu/drm/armada/armada_fbdev.c | 33 ++----
drivers/gpu/drm/ast/ast_fb.c | 47 +++------
drivers/gpu/drm/bochs/bochs_drv.c | 6 +-
drivers/gpu/drm/bochs/bochs_fbdev.c | 34 ++----
drivers/gpu/drm/cirrus/cirrus_drv.c | 7 +-
drivers/gpu/drm/cirrus/cirrus_fbdev.c | 39 ++-----
drivers/gpu/drm/drm_fb_cma_helper.c | 45 ++------
drivers/gpu/drm/drm_fb_helper.c | 142 ++++++++++++++++++++++++++
drivers/gpu/drm/exynos/exynos_drm_fbdev.c | 45 +++-----
drivers/gpu/drm/gma500/accel_2d.c | 6 +-
drivers/gpu/drm/gma500/framebuffer.c | 47 +++------
drivers/gpu/drm/i915/i915_dma.c | 3 +-
drivers/gpu/drm/i915/intel_fbdev.c | 40 +++-----
drivers/gpu/drm/mgag200/mgag200_drv.c | 3 +-
drivers/gpu/drm/mgag200/mgag200_fb.c | 36 ++-----
drivers/gpu/drm/mgag200/mgag200_main.c | 2 +-
drivers/gpu/drm/msm/msm_fbdev.c | 34 ++----
drivers/gpu/drm/nouveau/nouveau_drm.c | 3 +-
drivers/gpu/drm/nouveau/nouveau_fbcon.c | 38 +++----
drivers/gpu/drm/omapdrm/omap_fbdev.c | 34 ++----
drivers/gpu/drm/qxl/qxl_fb.c | 40 +++-----
drivers/gpu/drm/radeon/radeon_drv.c | 4 +-
drivers/gpu/drm/radeon/radeon_fb.c | 41 +++-----
drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c | 47 +++------
drivers/gpu/drm/tegra/fb.c | 40 +++-----
drivers/gpu/drm/udl/udl_fb.c | 40 +++-----
drivers/gpu/drm/virtio/virtgpu_drm_bus.c | 3 +-
drivers/gpu/drm/virtio/virtgpu_fb.c | 30 ++----
include/drm/drm_fb_helper.h | 30 ++++++
32 files changed, 426 insertions(+), 547 deletions(-)
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel
