Re: [PATCH:libdrm] include <sys/types.h> & <sys/mkdev.h> directly for major() and minor()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 07/ 8/15 10:59 AM, Emil Velikov wrote:
On 8 July 2015 at 18:41, Alan Coopersmith <alan.coopersmith@xxxxxxxxxx> wrote:
Linux seems to pick these up via another header, but Solaris needs them
explictly included, or we get undefined symbol errors for major & minor.

v2: use headers documented in makedev(3C) man page instead of sysmacros.h

Signed-off-by: Alan Coopersmith <alan.coopersmith@xxxxxxxxxx>
---
  libkms/linux.c |    2 ++
  1 file changed, 2 insertions(+)

diff --git a/libkms/linux.c b/libkms/linux.c
index 4d47148..53e03c3 100644
--- a/libkms/linux.c
+++ b/libkms/linux.c
@@ -40,6 +40,8 @@
  #include <string.h>
  #include <unistd.h>
  #include <sys/stat.h>
+#include <sys/types.h>
+#include <sys/mkdev.h>
I'll add the HAVE_SYS_MKDEV_H guard around the latter, and push this
in the next few days. Unless someone objects that is ;-)

Oh, whoops, I forgot to check if there was a guard needed - that sounds
great to me, thanks.

--
	-Alan Coopersmith-              alan.coopersmith@xxxxxxxxxx
	 Oracle Solaris Engineering - http://blogs.oracle.com/alanc
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux