On 08.07.2015 02:41, Jerome Glisse wrote: > On Tue, Jul 07, 2015 at 03:39:29PM +0900, Michel Dänzer wrote: >> On 07.07.2015 01:10, Jerome Glisse wrote: >>> >>> In meantime i think we need to apply this patch as it is really a fix to >>> make the code actually do what the comment and design pretends it does. >> >> I agree. >> >> BTW, maybe it should be split up into the actual fix (removing the >> npages assignment) and the NUM_PAGES_TO_ALLOC related simplification? > > This would make 2 really small patch, patch is small as it is :) But why > not. It's not about size but about having one commit for each logical change. It took me a while to realize that the NUM_PAGES_TO_ALLOC changes aren't directly related to the fix, and I've seen the same thing happen to others. -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
