On Mon, Jun 29, 2015 at 02:16:17PM +1000, Dave Airlie wrote: > On 6 February 2015 at 22:18, Thierry Reding <thierry.reding@xxxxxxxxx> wrote: > > On Fri, Jan 30, 2015 at 01:57:01PM -0500, Sean Paul wrote: > >> On 64-bit targets, tegra_gem_mmap doesn't return the > >> offset to userspace. As such, subsequent calls to mmap(2) > >> fail. Alter the args to use 64-bit offset to fix this. > >> > >> Signed-off-by: Sean Paul <seanpaul@xxxxxxxxxxxx> > >> --- > >> include/uapi/drm/tegra_drm.h | 3 ++- > >> 1 file changed, 2 insertions(+), 1 deletion(-) > > > > I've applied this with a slightly tweaked commit message. > > Doesn't that break 32-bit ABI? Yes it does. This was discussed earlier in this thread. The original patch was to add a separate IOCTL to be used on 64-bit architectures because the 32-bit IOCTL was broken. After some discussion everybody involved agreed that it'd be best to fix the IOCTL while we can (the driver-specific IOCTLs in the Tegra driver are all guarded by the STAGING Kconfig symbol). Thierry
Attachment:
pgp0r5UNfOyBE.pgp
Description: PGP signature
_______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
