2015-06-22 20:42 GMT+09:00 Inki Dae <inki.dae@xxxxxxxxxxx>: > + Krzysztof > > On 2015년 06월 22일 18:10, Inki Dae wrote: >> On 2015년 06월 12일 21:59, Hyungwon Hwang wrote: >>> The clock which was named as 'pll_clk' is actually not the clock source >>> of PLL in MIPI DSI. This patch fixes this disagreement. >> >> Mr. Kukjin and Krzysztof, can you give me Acked-by or Singed-off-by? I'd >> like to merge this patch to mainline through drm-next. Dear Hyungwon Hwang, Please always CC samsung-soc mailing list on such patches. I won't receive it on my personal email if you don't CC the list. The get_maintainers.pl gives necessary addresses. Comment below, >> >> Thanks, >> Inki Dae >> >>> >>> Signed-off-by: Hyungwon Hwang <human.hwang@xxxxxxxxxxx> >>> --- >>> Changes before: >>> - Refer https://patchwork.kernel.org/patch/6191811 >>> Changes for v6: >>> - None >>> >>> arch/arm/boot/dts/exynos4.dtsi | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi >>> index e20cdc2..1538d7a 100644 >>> --- a/arch/arm/boot/dts/exynos4.dtsi >>> +++ b/arch/arm/boot/dts/exynos4.dtsi >>> @@ -167,7 +167,7 @@ >>> phys = <&mipi_phy 1>; >>> phy-names = "dsim"; >>> clocks = <&clock CLK_DSIM0>, <&clock CLK_SCLK_MIPI0>; >>> - clock-names = "bus_clk", "pll_clk"; >>> + clock-names = "bus_clk", "sclk_mipi"; It seems wrong. The driver fetches reference from a name of "pll_clk", not "sclk_mipi". Also bindings documentation mentions pll_clk and bus_clk only. Best regards, Krzysztof >>> status = "disabled"; >>> #address-cells = <1>; >>> #size-cells = <0>; >>> -- >>> 1.9.1 >>> >>> -- >>> To unsubscribe from this list: send the line "unsubscribe devicetree" in >>> the body of a message to majordomo@xxxxxxxxxxxxxxx >>> More majordomo info at http://vger.kernel.org/majordomo-info.html >>> >> > _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
