Hi Joonyoung, 2015-06-12 Joonyoung Shim <jy0922.shim@xxxxxxxxxxx>: > With atomic modesetting all the control for CRTC, Planes, Encoders and > Connectors should come from DRM core, so the driver is not allowed to > enable or disable planes from inside the crtc_enable()/disable() call. > > But it needs to disable planes with crtc_disable in exynos driver > internally. Because crtc is disabled before plane is disabled, it means > plane_disable just returns without any register changes, then we cannot > be sure setting register to disable plane when crtc is disable. > > This patch removes this chainned calls to enable plane from exynos hw > drivers code letting only DRM core touch planes except to disable plane. > Also it leads eliminable enabled and resume of struct exynos_drm_plane. > > Signed-off-by: Gustavo Padovan <gustavo.padovan@xxxxxxxxxxxxxxx> > Signed-off-by: Joonyoung Shim <jy0922.shim@xxxxxxxxxxx> > Tested-by: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx> > --- > This patch was modified from original patch of Gustavo Padovan - > http://www.spinics.net/lists/linux-samsung-soc/msg45351.html > > v2 changes: > - add 1/3 additional patch to remove waiting vblank in mixer. > - rebase this from 1/3 patch. > - add 3/3 additional patch to fix IOMMU page fault of fimd. > > drivers/gpu/drm/exynos/exynos7_drm_decon.c | 63 +++--------------------------- > drivers/gpu/drm/exynos/exynos_drm_drv.h | 5 --- > drivers/gpu/drm/exynos/exynos_drm_fimd.c | 63 +++--------------------------- > drivers/gpu/drm/exynos/exynos_drm_vidi.c | 27 ------------- > drivers/gpu/drm/exynos/exynos_mixer.c | 38 ++---------------- > 5 files changed, 16 insertions(+), 180 deletions(-) Reviewed-by: Gustavo Padovan <gustavo.padovan@xxxxxxxxxxxxxxx> Gustavo _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
