Hello Gustavo, On Tue, Jun 2, 2015 at 4:06 PM, Gustavo Padovan <gustavo@xxxxxxxxxxx> wrote: > Hi Inki, > > 2015-06-02 Inki Dae <inki.dae@xxxxxxxxxxx>: > >> Hi, >> >> On 2015년 06월 02일 00:04, Gustavo Padovan wrote: >> > From: Gustavo Padovan <gustavo.padovan@xxxxxxxxxxxxxxx> >> > >> > To follow more closely the new atomic API we split the dpms() >> > helper into the enable() and disable() helper to get exactly the >> > same semantics. >> >> Below is the result from checkpatch.pl. Please fix all errors and check >> your patch with checkpatch.pl before posting it. >> >> Thanks, >> Inki Dae >> >> total: 62 errors, 0 warnings, 410 lines checked > > I think you did something wrong when checking, for me it looks like > this: > > 0016-drm-exynos-split-exynos_crtc-dpms-in-enable-and-disa.patch has no > obvious style problems and is ready for submission. > WARNING: Do not use whitespace before Signed-off-by: > #12: > Signed-off-by: Gustavo Padovan <gustavo.padovan@xxxxxxxxxxxxxxx> > > total: 0 errors, 1 warnings, 594 lines checked > I also don't get any checkpatch.pl error or warnings when testing your patch: $ pwclient get 6523251 Saved patch to v10-17-17-drm-exynos-split-exynos_crtc--dpms-in-enable-and-disable.patch.0 $ ./scripts/checkpatch.pl v10-17-17-drm-exynos-split-exynos_crtc--dpms-in-enable-and-disable.patch total: 0 errors, 0 warnings, 410 lines checked v10-17-17-drm-exynos-split-exynos_crtc--dpms-in-enable-and-disable.patch has no obvious style problems and is ready for submission. > Gustavo Best regards, Javier _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
