On 28 May 2015 at 18:52, Pierre Moreau <pierre.morrow@xxxxxxx> wrote: > Hi Dave, > > > ----- Mail original ----- >> Changes since v1: > [...] >> diff --git a/drm/nouveau/nouveau_vga.c b/drm/nouveau/nouveau_vga.c >> index 9a6328f..7b13804 100644 >> --- a/drm/nouveau/nouveau_vga.c >> +++ b/drm/nouveau/nouveau_vga.c >> @@ -36,7 +36,7 @@ nouveau_switcheroo_set_state(struct pci_dev *pdev, >> { >> struct drm_device *dev = pci_get_drvdata(pdev); >> >> - if ((nouveau_is_optimus() || nouveau_has_mux()) && state == >> VGA_SWITCHEROO_OFF) > > If I understand it correctly, if the laptop is an Optimus one or has a mux, we are not "allowed" to opt-out of DynPwr/DynOff by powering down the card? > In the same commit adding this conditional (5addcf0a5f0fadceba6bd562d0616a1c5d4c1a4d), you added the possibility to enable/disable dynpm. How is it supposed to work, by simply echo'ing ON or OFF to vga_switcheroo/switch? Then I probably forgot some stuff as it doesn't want to work on my laptop. > I can't remember to be honest I think I wanted to stop the user from changing the state if it was dynamic, now if you turn off dynpm then you should probably enable that. Dave. _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel