Re: [PATCH] drm: clean up drm_mm debugfs output

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, May 28, 2015 at 5:36 AM, Russell King
<rmk+kernel@xxxxxxxxxxxxxxxx> wrote:
> The drm_mm debugfs output is difficult to read as two different formats
> are used for the addresses:
>
> 0x00000080000000-0x0000008000b000: 45056: used
> 0x8000b000-0x80016000: 45056: free
> 0x00000080016000-0x0000008001b000: 20480: used
> 0x8001b000-0x817a1000: 24666112: free
> 0x000000817a1000-0x000000817a8000: 28672: used
> 0x000000817a8000-0x00000081ba8000: 4194304: used
>
> Fix this by using %#018llx for all addresses, thus making the output:
>
> 0x0000000080000000-0x000000008000b000: 45056: used
> 0x000000008000b000-0x0000000080016000: 45056: free
> 0x0000000080016000-0x000000008001b000: 20480: used
> 0x000000008001b000-0x00000000817a1000: 24666112: free
> 0x00000000817a1000-0x00000000817a8000: 28672: used
> 0x00000000817a8000-0x0000000081ba8000: 4194304: used
>
> Signed-off-by: Russell King <rmk+kernel@xxxxxxxxxxxxxxxx>

Reviewed-by: Alex Deucher <alexander.deucher@xxxxxxx>

> ---
> David,
>
> Please apply this patch; I didn't see the need to create a new branch
> just for one patch.  Thanks.
>
>  drivers/gpu/drm/drm_mm.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_mm.c b/drivers/gpu/drm/drm_mm.c
> index 1134526286c8..3427b115e2bb 100644
> --- a/drivers/gpu/drm/drm_mm.c
> +++ b/drivers/gpu/drm/drm_mm.c
> @@ -825,7 +825,7 @@ static u64 drm_mm_dump_hole(struct seq_file *m, struct drm_mm_node *entry)
>                 hole_start = drm_mm_hole_node_start(entry);
>                 hole_end = drm_mm_hole_node_end(entry);
>                 hole_size = hole_end - hole_start;
> -               seq_printf(m, "%#llx-%#llx: %llu: free\n", hole_start,
> +               seq_printf(m, "%#018llx-%#018llx: %llu: free\n", hole_start,
>                            hole_end, hole_size);
>                 return hole_size;
>         }
> @@ -846,7 +846,7 @@ int drm_mm_dump_table(struct seq_file *m, struct drm_mm *mm)
>         total_free += drm_mm_dump_hole(m, &mm->head_node);
>
>         drm_mm_for_each_node(entry, mm) {
> -               seq_printf(m, "%#016llx-%#016llx: %llu: used\n", entry->start,
> +               seq_printf(m, "%#018llx-%#018llx: %llu: used\n", entry->start,
>                            entry->start + entry->size, entry->size);
>                 total_used += entry->size;
>                 total_free += drm_mm_dump_hole(m, entry);
> --
> 2.1.0
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@xxxxxxxxxxxxxxxxxxxxx
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel





[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux