On Tue, May 26, 2015 at 5:14 AM, Michel Dänzer <michel@xxxxxxxxxxx> wrote: > From: Michel Dänzer <michel.daenzer@xxxxxxx> > > drm_vblank_pre/post_modeset work fine for the radeon driver even though > it uses hardware counters, including suspend/resume. > > Signed-off-by: Michel Dänzer <michel.daenzer@xxxxxxx> Reviewed-by: Alex Deucher <alexander.deucher@xxxxxxx> > --- > drivers/gpu/drm/drm_irq.c | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/drivers/gpu/drm/drm_irq.c b/drivers/gpu/drm/drm_irq.c > index f9634da..0dcd73d 100644 > --- a/drivers/gpu/drm/drm_irq.c > +++ b/drivers/gpu/drm/drm_irq.c > @@ -1346,13 +1346,6 @@ EXPORT_SYMBOL(drm_crtc_vblank_on); > * software-side vblank frame counting will ensure that there are no jumps or > * discontinuities. > * > - * Unfortunately this approach is racy and also doesn't work when the vblank > - * interrupt stops running, e.g. across system suspend resume. It is therefore > - * highly recommended that drivers use the newer drm_vblank_off() and > - * drm_vblank_on() instead. drm_vblank_pre_modeset() only works correctly when > - * using "cooked" software vblank frame counters and not relying on any hardware > - * counters. > - * > * Drivers must call drm_vblank_post_modeset() when re-enabling the same crtc > * again. > */ > -- > 2.1.4 > > _______________________________________________ > dri-devel mailing list > dri-devel@xxxxxxxxxxxxxxxxxxxxx > http://lists.freedesktop.org/mailman/listinfo/dri-devel _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
