Hello,
On Tue, May 19, 2015 at 10:06:54AM +0200, Thierry Reding wrote:
> On Tue, May 19, 2015 at 09:03:49AM +0200, Uwe Kleine-König wrote:
> > Since 39b2bbe3d715 (gpio: add flags argument to gpiod_get*() functions)
> > which appeared in v3.17-rc1, the gpiod_get* functions take an additional
> > parameter that allows to specify direction and initial value for output.
> >
> > Use this to simplify the driver. Furthermore this is one caller less
> > that stops us making the flags argument to gpiod_get*() mandatory.
> >
> > Fixes: b2ea8772799d ("drm/bridge: Add I2C based driver for ps8622/ps8625 bridge")
>
> There's no need for this. The patch refactors code, but it doesn't fix
> anything. Including a "Fixes:" line will cause people to pick this up
> for stable releases, which I don't think is warranted in this case.
>
> I've applied the patch with the "Fixes:" line removed.
I added the line because at some near point in time I want to make the
flags argument mandatory and then it's a bug to not pass it. Do the
stable guys really pick patches that have Fixes: but not Cc: stable?
But I don't feel strong here. If you pick the patch up, everything
should be fine.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel
