Hi, On 13 May 2015 at 16:23, CK Hu <ck.hu@xxxxxxxxxxxx> wrote: > + /* > + * copy the mode data adjusted by mode_fixup() into crtc->mode > + * so that hardware can be seet to proper mode. > + */ > + memcpy(&crtc->mode, adjusted_mode, sizeof(*adjusted_mode)); Please do not do this. adjusted_mode is already available in crtc->hwmode. Please also restructure this driver to use the atomic infrastructure. A good example of how to do this can be found in the Rockchip RK3288 driver which was submitted a while ago: it started off as a legacy driver like this, but was converted during the submission phase. I'm sure there are many more comments to come, but certainly converting to be an atomic driver is the very first step. Cheers, Daniel _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
