Re: [PATCH 1/4] drm: Remove extraneous parameter from kerneldoc

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, May 09, 2015 at 03:52:10PM +0100, Daniel Stone wrote:
> 672cb1d6ae mistakenly added an extra parameter to the kerneldoc for
> drm_property_unreference_blob which wasn't actually present.
> 
> Signed-off-by: Daniel Stone <daniels@xxxxxxxxxxxxx>
> ---
>  drivers/gpu/drm/drm_crtc.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c
> index 4f922aa..6f3cafb 100644
> --- a/drivers/gpu/drm/drm_crtc.c
> +++ b/drivers/gpu/drm/drm_crtc.c
> @@ -4267,7 +4267,6 @@ static void drm_property_free_blob(struct kref *kref)
>   *
>   * Drop a reference on a blob property. May free the object.
>   *
> - * @param dev  Device the blob was created on

Same issue with drm_property_unreference_blob_locked. Also this isn't
kerneldoc syntax, the proper one is

 * @blob: Pointer to blob property

$ make htmldocs complains about a bunch of your recently added kerneldoc
still. I've squashed this one in, but can you pls follow up with more
fixups (and respin the later patches in this series too)?

Thanks, Daniel

>   * @param blob Pointer to blob property
>   */

>  void drm_property_unreference_blob(struct drm_property_blob *blob)
> -- 
> 2.4.0
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@xxxxxxxxxxxxxxxxxxxxx
> http://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel





[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux