Re: [PATCH 2/2] Fix one warning (v2)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 28 April 2015 at 15:43, Jan Vesely <jan.vesely@xxxxxxxxxxx> wrote:
> On Mon, 2015-04-27 at 10:29 +0800, Jammy Zhou wrote:
>> xf86drm.c:356:2: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
>>   group = (serv_group >= 0) ? serv_group : DRM_DEV_GID;
>>   ^
>>
>> v2: do 'int' cast to fix the warning
>>
>> Signed-off-by: Jammy Zhou <Jammy.Zhou@xxxxxxx>
>
> FWIW
> Reviewed-by: Jan Vesely <jan.vesely@xxxxxxxxxxx>
>
> Emil, are you OK with this approach?
>
Ideally one of the old school devs will chip in, but this looks good imho.
Lets give it a week or so for other interested parties to chip-in.

-Emil
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel





[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux