Hi Tobias, 2015-04-24 Tobias Jakobi <tjakobi@xxxxxxxxxxxxxxxxxxxxx>: > On 2015-04-24 03:48, Joonyoung Shim wrote: > >Hi Tobias, > > > >On 04/23/2015 09:12 PM, Tobias Jakobi wrote: > >>Move the defines for the pixelformats that the mixer supports out > >>of mixer_graph_buffer() to the top of the source. > >>Then select the mixer pixelformat (pf) in mixer_graph_buffer() based on > >>the plane's pf (and not bpp). > >>Also add handling of RGB565 and XRGB1555 to the switch statement and > >>exit early if the plane has an unsupported pf. > >> > >>Partially based on 'drm/exynos: enable/disable blend based on pixel > >>format' by Gustavo Padovan <gustavo.padovan@xxxxxxxxxxxxxxx>. > >> > >>Signed-off-by: Tobias Jakobi <tjakobi@xxxxxxxxxxxxxxxxxxxxx> > >>--- > >> drivers/gpu/drm/exynos/exynos_mixer.c | 32 > >>++++++++++++++++++++++---------- > >> 1 file changed, 22 insertions(+), 10 deletions(-) > >> > >>diff --git a/drivers/gpu/drm/exynos/exynos_mixer.c > >>b/drivers/gpu/drm/exynos/exynos_mixer.c > >>index fbec750..1bd23ee 100644 > >>--- a/drivers/gpu/drm/exynos/exynos_mixer.c > >>+++ b/drivers/gpu/drm/exynos/exynos_mixer.c > >>@@ -44,6 +44,12 @@ > >> #define MIXER_WIN_NR 3 > >> #define MIXER_DEFAULT_WIN 0 > >> > >>+/* The pixelformats that are natively supported by the mixer. */ > >>+#define MIXER_PIXELFORMAT_RGB565 4 > >>+#define MIXER_PIXELFORMAT_ARGB1555 5 > >>+#define MIXER_PIXELFORMAT_ARGB4444 6 > >>+#define MIXER_PIXELFORMAT_ARGB8888 7 > >>+ > > > >Seems be long, how about s/PIXELFORMAT/FORMAT or just MIXER_RGB565 ... ? > >Please use tab between define name and value. > How about MXR_FORMAT_XYZ, to stay consistent with the regs-mixer header? I'm fine with MXR_FORMAT_XYZ. Other than that: Reviewed-by: Gustavo Padovan <gustavo.padovan@xxxxxxxxxxxxxxx> Gustavo _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
