On Tue, Apr 21, 2015 at 02:16:56PM +0200, Lukas Wunner wrote:
> Hi Chris,
>
> On Tue, Apr 21, 2015 at 12:50:10PM +0100, Chris Wilson wrote:
> > On Sun, Apr 19, 2015 at 05:01:17PM +0200, Lukas Wunner wrote:
> > > +cleanup_gem:
> > > + DRM_ERROR("failed to reinitialize fbdev\n");
> > > + mutex_lock(&dev->struct_mutex);
> > > + i915_gem_cleanup_ringbuffer(dev);
> > > + i915_gem_context_fini(dev);
> > > + mutex_unlock(&dev->struct_mutex);
> >
> > This is a bit random since you don't initialize GEM here and presumably
> > the GPU is still available even if it has no outputs.
>
> Hm, I copied this verbatim from i915_dma.c:i915_load_modeset_init(),
> I was under the impression that this is required if fbdev initialization
> failed. Am I missing something?
Just that we haven't given much thought to its error path before. Here
it's even more different since we already have a working GEM, just no
connectors.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel
