Hi Joonyoung,
2015-04-09 Joonyoung Shim <jy0922.shim@xxxxxxxxxxx>:
> Don't call directly disable callback of plane helper, we need to
> disconnect the plane from the fb and crtc after disable callback.
>
> Signed-off-by: Joonyoung Shim <jy0922.shim@xxxxxxxxxxx>
> ---
> drivers/gpu/drm/exynos/exynos_drm_crtc.c | 5 +----
> drivers/gpu/drm/exynos/exynos_drm_encoder.c | 2 +-
> 2 files changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_crtc.c b/drivers/gpu/drm/exynos/exynos_drm_crtc.c
> index 519c569..50c830e 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_crtc.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_crtc.c
> @@ -48,7 +48,6 @@ static void exynos_drm_crtc_disable(struct drm_crtc *crtc)
> {
> struct exynos_drm_crtc *exynos_crtc = to_exynos_crtc(crtc);
> struct drm_plane *plane;
> - int ret;
>
> if (!exynos_crtc->enabled)
> return;
> @@ -69,9 +68,7 @@ static void exynos_drm_crtc_disable(struct drm_crtc *crtc)
> if (plane->crtc != crtc)
> continue;
>
> - ret = plane->funcs->disable_plane(plane);
> - if (ret)
> - DRM_ERROR("Failed to disable plane %d\n", ret);
> + drm_plane_force_disable(plane);
> }
Which tree did you based this code? I've removed all this code in atomic.
These two pieces of code makes no sense in atomic modesetting, disable would
be called from the drm atomic core there.
Gustavo
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel
