On Wed, Apr 01, 2015 at 10:04:03AM +0800, Yakir wrote: > Hi Russell, > > 在 2015/3/31 17:13, Russell King - ARM Linux 写道: > >As for the channel number, this is intentionally left to the driver - > >most cases I've found either the driver isn't interested, or where > >they are interested (the only case I know of is my dw_hdmi ahb audio > >driver), it's more appropriate to generate a baseline channel status, > >and let the driver iterate over the channels adding the appropriate > >channel number in. > Okay, agree with you to keep baseline channel status, but seems dw_hdmi > i2s audio are interested in channle number (to fill in schnl resigeters). Correct - but it's pointless having it in this helper as I explained. Please read my dw_hdmi-ahb-audio code to see why. It would be wasteful to memset the structure back to zero, only to re-fill it with exactly the same data except for the channel number. -- FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up according to speedtest.net. _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
