Re: [PATCH libdrm 7/9] tests/random: return non-zero on test failure

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 2015-03-22 at 22:03 +0000, Emil Velikov wrote:
> ... and wire it up to make check
> 
> Signed-off-by: Emil Velikov <emil.l.velikov@xxxxxxxxx>
> ---
>  tests/Makefile.am | 6 +++---
>  tests/random.c    | 6 ++++--
>  2 files changed, 7 insertions(+), 5 deletions(-)
> 
> diff --git a/tests/Makefile.am b/tests/Makefile.am
> index 9b13b2e..0603241 100644
> --- a/tests/Makefile.am
> +++ b/tests/Makefile.am
> @@ -29,15 +29,15 @@ LDADD = $(top_builddir)/libdrm.la
>  
>  check_PROGRAMS = \
>  	dristat \
> -	drmstat \
> -	random
> +	drmstat
>  
>  if HAVE_NOUVEAU
>  SUBDIRS += nouveau
>  endif
>  
>  TESTS = \
> -	hash
> +	hash \
> +	random
>  
>  if HAVE_LIBUDEV
>  
> diff --git a/tests/random.c b/tests/random.c
> index 6dc8386..6af7d33 100644
> --- a/tests/random.c
> +++ b/tests/random.c
> @@ -107,15 +107,17 @@ int main(void)
>  {
>      RandomState   *state;
>      int           i;
> +    int           ret;
>      unsigned long rand;
>  
>      state = drmRandomCreate(1);
>      for (i = 0; i < 10000; i++) {
>  	rand = drmRandom(state);
>      }
> +    ret = rand - state->check;

Since you are touching this line, I think rand != state->check would be
more readable.

>      printf("After 10000 iterations: %lu (%lu expected): %s\n",
>  	   rand, state->check,
> -	   rand - state->check ? "*INCORRECT*" : "CORRECT");
> +	   ret ? "*INCORRECT*" : "CORRECT");
>      drmRandomDestroy(state);
>  
>      printf("Checking periods...\n");
> @@ -123,5 +125,5 @@ int main(void)
>      check_period(2);
>      check_period(31415926);
>      
> -    return 0;
> +    return ret;
>  }

-- 
Jan Vesely <jan.vesely@xxxxxxxxxxx>

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux