On Tue, Mar 24, 2015 at 12:52:44PM +0100, Philipp Zabel wrote: > Am Dienstag, den 24.03.2015, 12:34 +0100 schrieb Thierry Reding: > [...] > > > > Would you prefer > > > > struct display_timing *(*get_timing)(struct drm_panel *panel); > > > > ? > > > > > > I'd like to resend this. Please let me know if you want me to change > > > this function prototype. > > > > I have no objections to keeping the current prototype. It's something we > > can always fixup if we want to. Also keeping the symmetry with min/max > > values for hactive and vactive is okay in my opinion. > > > > Were there any other remaining points? If not I'll just apply this as > > is. > > No, I'm happy if you apply this as is. Done. I touched up a couple of things in the commit messages and made a minor change to the loop which copies the timings in the simple-panel driver (extract the min(num_timings, p->desc->num_timings) out of the for statement). Nothing major, but it might still be good if you could test, just to make sure I didn't make a mess. This should be in tomorrow's linux-next, but if you want to take a peek before that, you can grab it from here: git://anongit.freedesktop.org/tegra/linux.git#drm/panel/for-next Thierry
Attachment:
pgpKhCzjznsLD.pgp
Description: PGP signature
_______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
