Hi Daniel,
I've modified my patches and resend them, hope I do the right work flow this time.
I am not good at english, so please forgive my dull :-(
I spent about two hours to figure out what does the "sob line missing" means.
sob means Signed-off-by in case some others don't know. :-)
Please don't hesitate to criticize if I think I didn't do the right thing.
Thanks, John
On Mon, Mar 16, 2015 at 4:21 PM, Daniel Vetter <daniel@xxxxxxxx> wrote:
On Sun, Mar 15, 2015 at 08:59:11PM +0800, John Hunter wrote:
> I'm not sure whether this is right, as far as I can see, for the
> macro 'list_for_each_entry', if not use the tmp_connector, it does
> make sense.
>
> Hope I am right with that.
Nice catch and looks correct. But please follow patch submission
guidelines from Documentation/SubmittingPatches. Here specifically:
- sob line missing
- Additional comments/questions should be below a line with just '---' so
that git apply-mbox drops it.
- Polish the commit message a bit. This wasn't too harmful since we
already look at connector, which has the same effect as the loop for any
non-cloned configs. Only when we have a cloned configuration is it
important to look at other connectors. Furthermore existing userspace
always changes dpms on all of them anyway.
Thanks, Daniel
> ---
> drivers/gpu/drm/drm_atomic_helper.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atomic_helper.c
> index bc17019..2abded1 100644
> --- a/drivers/gpu/drm/drm_atomic_helper.c
> +++ b/drivers/gpu/drm/drm_atomic_helper.c
> @@ -2027,10 +2027,10 @@ retry:
> WARN_ON(!drm_modeset_is_locked(&config->connection_mutex));
>
> list_for_each_entry(tmp_connector, &config->connector_list, head) {
> - if (connector->state->crtc != crtc)
> + if (tmp_connector->state->crtc != crtc)
> continue;
>
> - if (connector->dpms == DRM_MODE_DPMS_ON) {
> + if (tmp_connector->dpms == DRM_MODE_DPMS_ON) {
> active = true;
> break;
> }
> --
> 1.9.1
>
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@xxxxxxxxxxxxxxxxxxxxx
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel
Best regards
Junwang Zhao
Microprocessor Research and Develop Center
Department of Computer Science &Technology
Peking University
Beijing, 100871, PRC
_______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
