On Mon, Mar 09, 2015 at 08:10:06AM +0800, Zhigang Gong wrote: > > -----Original Message----- > > From: Beignet [mailto:beignet-bounces@xxxxxxxxxxxxxxxxxxxxx] On Behalf Of > > Jeff McGee > > Sent: Saturday, March 7, 2015 2:44 AM > > To: Zhigang Gong > > Cc: daniel@xxxxxxxx; intel-gfx@xxxxxxxxxxxxxxxxxxxxx; > > beignet@xxxxxxxxxxxxxxxxxxxxx; dri-devel@xxxxxxxxxxxxxxxxxxxxx > > Subject: Re: [Beignet] [PATCH] drm/i915: Export total subslice and EU counts > > > > On Thu, Mar 05, 2015 at 12:35:55PM +0800, Zhigang Gong wrote: > > > There is one minor conflict when apply the KMD patch to latest > > > drm-intel-nightly branch. It should be easy to fix. > > > > > > Another issue is that IMO, we should bump libdrm's version number when > > > increase these new APIs. Then in Beignet, we can check the libdrm > > > version at build time and determine whether we will use these new > > > interfaces. Thus, we can avoid breaking beignet on those systems which > > > have previous libdrm/kernel installed. > > > > > Right. I can append a libdrm patch to bump the version. And then I suppose I > > will follow the process to make a new release. Not sure right now how that > > works. First time going through it. > > > > Also, how should we test for the libdrm version and conditionally use the API? > We can check the libdrm version at configuration time and define a macro to > indicate whether we can use these new APIs in beignet. > > Is there a previous example of this in Beignet that I could follow? > Yes, one example is userptr. You can check the usage of DRM_INTEL_USERPTR and HAS_USERPTR > In beignet. Ok, applied the kernel patch. Please go ahead with libdrm&beignet parts. Thanks, Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
