Just a few nits, I'm afraid.
On Wed, 2015-03-11 at 14:18 +0800, CK Hu wrote:
> drivers/gpu/drm/bridge/Kconfig | 10 +
> drivers/gpu/drm/bridge/Makefile | 1 +
I applied 1/2 and 2/2 on top of next-20150312 to check a trivial issue.
The chunks for these two files needed context changes to git this patch
applied.
> drivers/gpu/drm/bridge/it6151.c | 601 ++++++++++++++++++++++++++++++++++++++++
> include/drm/bridge/it6151.h | 34 +++
> 4 files changed, 646 insertions(+)
> create mode 100644 drivers/gpu/drm/bridge/it6151.c
> create mode 100644 include/drm/bridge/it6151.h
> diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
> index f38bbcd..2b3a78e 100644
> --- a/drivers/gpu/drm/bridge/Kconfig
> +++ b/drivers/gpu/drm/bridge/Kconfig
> @@ -11,3 +11,13 @@ config DRM_PTN3460
> select DRM_PANEL
> ---help---
> ptn3460 eDP-LVDS bridge chip driver.
> +
> +config DRM_IT6151
> + bool "Enable IT6151FN : MIPI to eDP Converter"
> + depends on DRM
> + select DRM_KMS_HELPER
> + help
> + Choose this option if you have IT6151 for display
> + The IT6151 is a high-performance and low-power
> + MIPI to eDP converter
> +
(This empty line makes git am whine: "new blank line at EOF.".)
> --- /dev/null
> +++ b/drivers/gpu/drm/bridge/it6151.c
> +#include <linux/module.h>
This file can only be built-in. So I couldn't help but notice this
include. And if I remove it
make drivers/gpu/drm/bridge/it6151.o
still runs without warning or errors. Unless I've missed something
non-obvious I'd say it is not needed.
> +
(Empty line at end of file.)
> --- /dev/null
> +++ b/include/drm/bridge/it6151.h
> +
(Another empty line at end of file.)
Paul Bolle
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel
