Hi Tobias,
On 2015년 02월 24일 23:20, Tobias Jakobi wrote:
> The coefficient mode enables use of global color, not alpha.
>
> Signed-off-by: Tobias Jakobi <tjakobi@xxxxxxxxxxxxxxxxxxxxx>
> ---
> exynos/exynos_fimg2d.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/exynos/exynos_fimg2d.h b/exynos/exynos_fimg2d.h
> index dbcb764..418757f 100644
> --- a/exynos/exynos_fimg2d.h
> +++ b/exynos/exynos_fimg2d.h
> @@ -159,7 +159,7 @@ enum e_g2d_coeff_mode {
> G2D_COEFF_MODE_DST_COLOR,
> /* Global Alpha : Set by ALPHA_REG(0x618) */
> G2D_COEFF_MODE_GB_ALPHA,
> - /* Global Alpha : Set by ALPHA_REG(0x618) */
> + /* Global Color : Set by ALPHA_REG(0x618) */
Actually, above register sets not only global color value but also
global alpha value. Below shows fields of the register,
ColorValue [31:8] Global color value (RGB order)
AlphaValue [7:0] Global alpha value
So right comment would be "Global Color and Global Alpha".
Thanks,
Inki Dae
> G2D_COEFF_MODE_GB_COLOR,
> /* (1-SRC alpha)/DST Alpha */
> G2D_COEFF_MODE_DISJOINT_S,
>
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel
