Re: [PATCH 3/9] drm/gma500: constify all struct drm_*_helper funcs pointers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Mar 11, 2015 at 10:51 AM, Jani Nikula <jani.nikula@xxxxxxxxx> wrote:
> They are not to be modified.
>
> Generated using the semantic patch:
>
> @@
> @@
> (
>   const struct drm_crtc_helper_funcs *
> |
> - struct drm_crtc_helper_funcs *
> + const struct drm_crtc_helper_funcs *
> )
>
> @@
> @@
> (
>   const struct drm_encoder_helper_funcs *
> |
> - struct drm_encoder_helper_funcs *
> + const struct drm_encoder_helper_funcs *
> )
>
> @@
> @@
> (
>   const struct drm_connector_helper_funcs *
> |
> - struct drm_connector_helper_funcs *
> + const struct drm_connector_helper_funcs *
> )
>
> @@
> @@
> (
>   const struct drm_plane_helper_funcs *
> |
> - struct drm_plane_helper_funcs *
> + const struct drm_plane_helper_funcs *
> )
>
> Signed-off-by: Jani Nikula <jani.nikula@xxxxxxxxx>

Reviewed-by: Patrik Jakobsson <patrik.r.jakobsson@xxxxxxxxx>

> ---
>  drivers/gpu/drm/gma500/cdv_intel_display.c   |  2 +-
>  drivers/gpu/drm/gma500/cdv_intel_hdmi.c      |  2 +-
>  drivers/gpu/drm/gma500/cdv_intel_lvds.c      |  2 +-
>  drivers/gpu/drm/gma500/gma_display.c         | 10 +++++-----
>  drivers/gpu/drm/gma500/mdfld_dsi_output.c    |  2 +-
>  drivers/gpu/drm/gma500/mdfld_intel_display.c |  2 +-
>  drivers/gpu/drm/gma500/oaktrail_crtc.c       |  2 +-
>  drivers/gpu/drm/gma500/oaktrail_hdmi.c       |  2 +-
>  drivers/gpu/drm/gma500/psb_intel_display.c   |  2 +-
>  drivers/gpu/drm/gma500/psb_intel_lvds.c      |  2 +-
>  10 files changed, 14 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/gpu/drm/gma500/cdv_intel_display.c b/drivers/gpu/drm/gma500/cdv_intel_display.c
> index 66727328832d..7d47b3d5cc0d 100644
> --- a/drivers/gpu/drm/gma500/cdv_intel_display.c
> +++ b/drivers/gpu/drm/gma500/cdv_intel_display.c
> @@ -823,7 +823,7 @@ static int cdv_intel_crtc_mode_set(struct drm_crtc *crtc,
>
>         /* Flush the plane changes */
>         {
> -               struct drm_crtc_helper_funcs *crtc_funcs =
> +               const struct drm_crtc_helper_funcs *crtc_funcs =
>                     crtc->helper_private;
>                 crtc_funcs->mode_set_base(crtc, x, y, old_fb);
>         }
> diff --git a/drivers/gpu/drm/gma500/cdv_intel_hdmi.c b/drivers/gpu/drm/gma500/cdv_intel_hdmi.c
> index 4268bf210034..6b1d3340ba14 100644
> --- a/drivers/gpu/drm/gma500/cdv_intel_hdmi.c
> +++ b/drivers/gpu/drm/gma500/cdv_intel_hdmi.c
> @@ -195,7 +195,7 @@ static int cdv_hdmi_set_property(struct drm_connector *connector,
>                                             encoder->crtc->x, encoder->crtc->y, encoder->crtc->primary->fb))
>                                         return -1;
>                         } else {
> -                               struct drm_encoder_helper_funcs *helpers
> +                               const struct drm_encoder_helper_funcs *helpers
>                                                     = encoder->helper_private;
>                                 helpers->mode_set(encoder, &crtc->saved_mode,
>                                              &crtc->saved_adjusted_mode);
> diff --git a/drivers/gpu/drm/gma500/cdv_intel_lvds.c b/drivers/gpu/drm/gma500/cdv_intel_lvds.c
> index 0b770396548c..211069b2b951 100644
> --- a/drivers/gpu/drm/gma500/cdv_intel_lvds.c
> +++ b/drivers/gpu/drm/gma500/cdv_intel_lvds.c
> @@ -505,7 +505,7 @@ static int cdv_intel_lvds_set_property(struct drm_connector *connector,
>                 else
>                          gma_backlight_set(encoder->dev, value);
>         } else if (!strcmp(property->name, "DPMS") && encoder) {
> -               struct drm_encoder_helper_funcs *helpers =
> +               const struct drm_encoder_helper_funcs *helpers =
>                                         encoder->helper_private;
>                 helpers->dpms(encoder, value);
>         }
> diff --git a/drivers/gpu/drm/gma500/gma_display.c b/drivers/gpu/drm/gma500/gma_display.c
> index 9bb9bddd881a..001b450b27b3 100644
> --- a/drivers/gpu/drm/gma500/gma_display.c
> +++ b/drivers/gpu/drm/gma500/gma_display.c
> @@ -501,20 +501,20 @@ bool gma_crtc_mode_fixup(struct drm_crtc *crtc,
>
>  void gma_crtc_prepare(struct drm_crtc *crtc)
>  {
> -       struct drm_crtc_helper_funcs *crtc_funcs = crtc->helper_private;
> +       const struct drm_crtc_helper_funcs *crtc_funcs = crtc->helper_private;
>         crtc_funcs->dpms(crtc, DRM_MODE_DPMS_OFF);
>  }
>
>  void gma_crtc_commit(struct drm_crtc *crtc)
>  {
> -       struct drm_crtc_helper_funcs *crtc_funcs = crtc->helper_private;
> +       const struct drm_crtc_helper_funcs *crtc_funcs = crtc->helper_private;
>         crtc_funcs->dpms(crtc, DRM_MODE_DPMS_ON);
>  }
>
>  void gma_crtc_disable(struct drm_crtc *crtc)
>  {
>         struct gtt_range *gt;
> -       struct drm_crtc_helper_funcs *crtc_funcs = crtc->helper_private;
> +       const struct drm_crtc_helper_funcs *crtc_funcs = crtc->helper_private;
>
>         crtc_funcs->dpms(crtc, DRM_MODE_DPMS_OFF);
>
> @@ -656,7 +656,7 @@ void gma_crtc_restore(struct drm_crtc *crtc)
>
>  void gma_encoder_prepare(struct drm_encoder *encoder)
>  {
> -       struct drm_encoder_helper_funcs *encoder_funcs =
> +       const struct drm_encoder_helper_funcs *encoder_funcs =
>             encoder->helper_private;
>         /* lvds has its own version of prepare see psb_intel_lvds_prepare */
>         encoder_funcs->dpms(encoder, DRM_MODE_DPMS_OFF);
> @@ -664,7 +664,7 @@ void gma_encoder_prepare(struct drm_encoder *encoder)
>
>  void gma_encoder_commit(struct drm_encoder *encoder)
>  {
> -       struct drm_encoder_helper_funcs *encoder_funcs =
> +       const struct drm_encoder_helper_funcs *encoder_funcs =
>             encoder->helper_private;
>         /* lvds has its own version of commit see psb_intel_lvds_commit */
>         encoder_funcs->dpms(encoder, DRM_MODE_DPMS_ON);
> diff --git a/drivers/gpu/drm/gma500/mdfld_dsi_output.c b/drivers/gpu/drm/gma500/mdfld_dsi_output.c
> index abf2248da61e..89f705c3a5eb 100644
> --- a/drivers/gpu/drm/gma500/mdfld_dsi_output.c
> +++ b/drivers/gpu/drm/gma500/mdfld_dsi_output.c
> @@ -290,7 +290,7 @@ static int mdfld_dsi_connector_set_property(struct drm_connector *connector,
>                                                 encoder->crtc->primary->fb))
>                                         goto set_prop_error;
>                         } else {
> -                               struct drm_encoder_helper_funcs *funcs =
> +                               const struct drm_encoder_helper_funcs *funcs =
>                                                 encoder->helper_private;
>                                 funcs->mode_set(encoder,
>                                         &gma_crtc->saved_mode,
> diff --git a/drivers/gpu/drm/gma500/mdfld_intel_display.c b/drivers/gpu/drm/gma500/mdfld_intel_display.c
> index 8cc8a5abbc7b..acd38344b302 100644
> --- a/drivers/gpu/drm/gma500/mdfld_intel_display.c
> +++ b/drivers/gpu/drm/gma500/mdfld_intel_display.c
> @@ -849,7 +849,7 @@ static int mdfld_crtc_mode_set(struct drm_crtc *crtc,
>
>         /* Flush the plane changes */
>         {
> -               struct drm_crtc_helper_funcs *crtc_funcs =
> +               const struct drm_crtc_helper_funcs *crtc_funcs =
>                     crtc->helper_private;
>                 crtc_funcs->mode_set_base(crtc, x, y, old_fb);
>         }
> diff --git a/drivers/gpu/drm/gma500/oaktrail_crtc.c b/drivers/gpu/drm/gma500/oaktrail_crtc.c
> index 2de216c2374f..1048f0c7c6ce 100644
> --- a/drivers/gpu/drm/gma500/oaktrail_crtc.c
> +++ b/drivers/gpu/drm/gma500/oaktrail_crtc.c
> @@ -483,7 +483,7 @@ static int oaktrail_crtc_mode_set(struct drm_crtc *crtc,
>
>         /* Flush the plane changes */
>         {
> -               struct drm_crtc_helper_funcs *crtc_funcs =
> +               const struct drm_crtc_helper_funcs *crtc_funcs =
>                     crtc->helper_private;
>                 crtc_funcs->mode_set_base(crtc, x, y, old_fb);
>         }
> diff --git a/drivers/gpu/drm/gma500/oaktrail_hdmi.c b/drivers/gpu/drm/gma500/oaktrail_hdmi.c
> index 54f73f50571a..2310d879cdc2 100644
> --- a/drivers/gpu/drm/gma500/oaktrail_hdmi.c
> +++ b/drivers/gpu/drm/gma500/oaktrail_hdmi.c
> @@ -347,7 +347,7 @@ int oaktrail_crtc_hdmi_mode_set(struct drm_crtc *crtc,
>
>         /* Flush the plane changes */
>         {
> -               struct drm_crtc_helper_funcs *crtc_funcs = crtc->helper_private;
> +               const struct drm_crtc_helper_funcs *crtc_funcs = crtc->helper_private;
>                 crtc_funcs->mode_set_base(crtc, x, y, old_fb);
>         }
>
> diff --git a/drivers/gpu/drm/gma500/psb_intel_display.c b/drivers/gpu/drm/gma500/psb_intel_display.c
> index b21a09451d1d..6659da88fe5b 100644
> --- a/drivers/gpu/drm/gma500/psb_intel_display.c
> +++ b/drivers/gpu/drm/gma500/psb_intel_display.c
> @@ -108,7 +108,7 @@ static int psb_intel_crtc_mode_set(struct drm_crtc *crtc,
>         struct drm_device *dev = crtc->dev;
>         struct drm_psb_private *dev_priv = dev->dev_private;
>         struct gma_crtc *gma_crtc = to_gma_crtc(crtc);
> -       struct drm_crtc_helper_funcs *crtc_funcs = crtc->helper_private;
> +       const struct drm_crtc_helper_funcs *crtc_funcs = crtc->helper_private;
>         int pipe = gma_crtc->pipe;
>         const struct psb_offset *map = &dev_priv->regmap[pipe];
>         int refclk;
> diff --git a/drivers/gpu/drm/gma500/psb_intel_lvds.c b/drivers/gpu/drm/gma500/psb_intel_lvds.c
> index 88aad95bde09..ce0645d0c1e5 100644
> --- a/drivers/gpu/drm/gma500/psb_intel_lvds.c
> +++ b/drivers/gpu/drm/gma500/psb_intel_lvds.c
> @@ -625,7 +625,7 @@ int psb_intel_lvds_set_property(struct drm_connector *connector,
>                 else
>                          gma_backlight_set(encoder->dev, value);
>         } else if (!strcmp(property->name, "DPMS")) {
> -               struct drm_encoder_helper_funcs *hfuncs
> +               const struct drm_encoder_helper_funcs *hfuncs
>                                                 = encoder->helper_private;
>                 hfuncs->dpms(encoder, value);
>         }
> --
> 2.1.4
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@xxxxxxxxxxxxxxxxxxxxx
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel





[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux