On Tue, Mar 10, 2015 at 05:34:35PM +0200, Ville Syrjälä wrote: > On Tue, Mar 10, 2015 at 05:14:58PM +0200, Jani Nikula wrote: > > On Tue, 10 Mar 2015, ville.syrjala@xxxxxxxxxxxxxxx wrote: > > > Make the helper function pointer structs const to make it clear they > > > should not be modified. > > > > So why not fix this once and for all? See the following patches. > > Why not indeed. I was being lazy and only hit the ones that caught my > eye while crawling through the atomic helper stuff. Well I pulled in your patch to drm-misc. Sounds like Jani still needs to fine-tune his cocci. -Daniel > > > > > This was quick cocci, can be split by driver too if so desired. > > > > BR, > > Jani. > > > > > > Jani Nikula (4): > > drm: constify all struct drm_encoder_helper_funcs pointers > > drm: constify all struct drm_connector_helper_funcs pointers > > drm: constify all struct drm_crtc_helper_funcs pointers > > drm: make encoder/connector/crtc helper_private a const pointer > > > > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 4 ++-- > > drivers/gpu/drm/drm_atomic_helper.c | 24 ++++++++++++------------ > > drivers/gpu/drm/drm_crtc_helper.c | 24 ++++++++++++------------ > > drivers/gpu/drm/drm_fb_helper.c | 8 ++++---- > > drivers/gpu/drm/drm_plane_helper.c | 2 +- > > drivers/gpu/drm/drm_probe_helper.c | 2 +- > > drivers/gpu/drm/exynos/exynos_hdmi.c | 2 +- > > drivers/gpu/drm/gma500/cdv_intel_display.c | 2 +- > > drivers/gpu/drm/gma500/cdv_intel_hdmi.c | 2 +- > > drivers/gpu/drm/gma500/cdv_intel_lvds.c | 2 +- > > drivers/gpu/drm/gma500/gma_display.c | 10 +++++----- > > drivers/gpu/drm/gma500/mdfld_dsi_output.c | 2 +- > > drivers/gpu/drm/gma500/mdfld_intel_display.c | 2 +- > > drivers/gpu/drm/gma500/oaktrail_crtc.c | 2 +- > > drivers/gpu/drm/gma500/oaktrail_hdmi.c | 2 +- > > drivers/gpu/drm/gma500/psb_intel_display.c | 2 +- > > drivers/gpu/drm/gma500/psb_intel_lvds.c | 2 +- > > drivers/gpu/drm/mgag200/mgag200_mode.c | 2 +- > > drivers/gpu/drm/nouveau/dispnv04/crtc.c | 4 ++-- > > drivers/gpu/drm/nouveau/dispnv04/dac.c | 6 +++--- > > drivers/gpu/drm/nouveau/dispnv04/dfp.c | 6 +++--- > > drivers/gpu/drm/nouveau/dispnv04/disp.c | 6 +++--- > > drivers/gpu/drm/nouveau/dispnv04/tvnv04.c | 4 ++-- > > drivers/gpu/drm/nouveau/dispnv04/tvnv17.c | 4 ++-- > > drivers/gpu/drm/nouveau/nouveau_connector.c | 4 ++-- > > drivers/gpu/drm/qxl/qxl_drv.c | 2 +- > > drivers/gpu/drm/radeon/radeon_connectors.c | 16 ++++++++-------- > > drivers/gpu/drm/radeon/radeon_legacy_encoders.c | 2 +- > > include/drm/drm_crtc.h | 6 +++--- > > include/drm/drm_crtc_helper.h | 6 +++--- > > 30 files changed, 81 insertions(+), 81 deletions(-) > > > > -- > > 2.1.4 > > -- > Ville Syrjälä > Intel OTC > _______________________________________________ > dri-devel mailing list > dri-devel@xxxxxxxxxxxxxxxxxxxxx > http://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
