Re: [PATCH v4 13/15] ASoC: codec/dw-hdmi-audio: add codec driver for dw hdmi audio

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





在 2015/3/2 17:15, Paul Bolle 写道:
On Sat, 2015-02-28 at 21:59 -0500, Yakir Yang wrote:
--- /dev/null
+++ b/sound/soc/codecs/dw-hdmi-audio.c
@@ -0,0 +1,379 @@
+/*
+ * dw-hdmi-codec.c
Doesn't match the filename. Is this line needed?

Thanks, this comment are good for read, and seems others codec driver also content this comment,
so I think we can keep this comment.
I will correct the file name it in next version.

Thanks for you reply :)

+ * DesignerWare ALSA SoC DAI driver for DW HDMI audio.
+ * Copyright (c) 2014,  CORPORATION. All rights reserved.
+ * Authors: Yakir Yang <ykk@xxxxxxxxxxxxxx>
+ *
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms and conditions of the GNU General Public License,
+ * version 2, as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
+ * more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.*
+ *
+ */
This states that the license is plain GPL v2.

(Missing empty line here.)

Okay, thanks, correct it in next version.

Thanks :)
+#include <linux/init.h>
[...]

+MODULE_LICENSE("GPL");
So you probably want
     MODULE_LICENSE("GPL v2");

here.
Okay, thanks, correct it in next version.

Thanks :)

Yakir Yang
Best regards.


Paul Bolle






_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel





[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux