On Wed, Mar 04, 2015 at 12:08:42PM +0100, Daniel Vetter wrote: > On Wed, Mar 04, 2015 at 10:38:08AM +0000, Chris Wilson wrote: > > + if (conn.encoder_id) { > > + r->count_encoders = 1; > > This only works for i915 where we only ever have 1 encoder. Other drivers > reassign encoders depending upon output type (e.g. dvi-i vs dvi-d). Imo > it'd be cleaner to do something like the below: Not quite. This value is the currently active encoder_id for the connector; there can only be one. As opposed to the array of associated encoders that we normally supply on ouptut. Even i915 has multiple encoders on connectors nowadays! -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel