On Fri, Feb 20, 2015 at 3:42 PM, Beeresh Gopal <gbeeresh@xxxxxxxxxxxxxx> wrote: > +/* Samsung framebuffer modifiers */ > + > +/* > + * NV12 64x32 Tiled > + * > + * 2 planes Y and CbCr, grouped into 64x32 macro tiles, > + * with a non-standard order in memory (Z-shape). > + * > + * Pixel layout identical to DRM_FORMAT_NV21 format: > + * index 0 = Y plane, [7:0] Y > + * index 1 = Cb:Cr plane, [15:0] Cb:Cr little endian > + */ > +#define DRM_FORMAT_MOD_SAMSUNG_64_32_TILE fourcc_mod_code(SAMSUNG, 1) This description mixes layout information with pixel format. Strictly speaking you could use this for other formats, but since the description doesn't mention whether this is in bytes or pixels that's a bit awkward. Or just mandatae that this can only be used with NV12 fourcc (and maybe add a check for that into the core drm code. Also, is this really samsung and not mpeg? -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
