On Mon, Feb 09, 2015 at 07:03:28PM +0100, Daniel Vetter wrote: > Just the usual paranoia ... > > Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxxx> > --- > drivers/gpu/drm/drm_crtc.c | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c > index b15d720eda4c..a12d7e8a0ca0 100644 > --- a/drivers/gpu/drm/drm_crtc.c > +++ b/drivers/gpu/drm/drm_crtc.c > @@ -3322,6 +3322,23 @@ static int framebuffer_check(const struct drm_mode_fb_cmd2 *r) > } > } > > + for (; i < 4; i++) { > + if (r->handles[i]) { > + DRM_DEBUG_KMS("buffer object handle for unused plane %d\n", i); Printing the invalid value is also useful. We tended to put user debugging messages as DRM_DEBUG(); would probably be useful to add DRM_DEBUG_USER() and clean up all the EINVAL reporting. -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel