Hi Inki,
On Mon, Dec 8, 2014 at 7:09 PM, Inki Dae <inki.dae@xxxxxxxxxxx> wrote:
>
>
> On 2014년 12월 07일 21:04, Ajay Kumar wrote:
>> This series is based on exynos-drm-next branch of Inki Dae's tree at:
>> git://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos.git
>>
>> DECON(Display and Enhancement Controller) is the new IP
>> in exynos7 SOC for generating video signals using pixel data.
>>
>> DECON driver can be used to drive 2 different interfaces on Exynos7:
>> DECON-INT(video controller) and DECON-EXT(Mixer for HDMI)
>>
>> The existing FIMD driver code was used as a template to create
>> DECON driver. Only DECON-INT is supported as of now, and
>> DECON-EXT support will be added later.
>>
>> Signed-off-by: Akshu Agrawal <akshua@xxxxxxxxx>
>> Signed-off-by: Ajay Kumar <ajaykumar.rs@xxxxxxxxxxx>
>> ---
>> Changes since V1:
>> -- Address comments from Pankaj and do few cleanups.
>> Changes since V2:
>> -- Address more comments from Pankaj and cleanup.
>>
>> .../devicetree/bindings/video/exynos7-decon.txt | 67 ++
>> drivers/gpu/drm/exynos/Kconfig | 13 +-
>> drivers/gpu/drm/exynos/Makefile | 1 +
>> drivers/gpu/drm/exynos/exynos7_drm_decon.c | 1042
> ++++++++++++++++++++
>> drivers/gpu/drm/exynos/exynos_drm_drv.c | 4 +
>> drivers/gpu/drm/exynos/exynos_drm_drv.h | 1 +
>> include/video/exynos7_decon.h | 346 +++++++
>> 7 files changed, 1471 insertions(+), 3 deletions(-)
>> create mode 100644
> Documentation/devicetree/bindings/video/exynos7-decon.txt
>> create mode 100644 drivers/gpu/drm/exynos/exynos7_drm_decon.c
>> create mode 100644 include/video/exynos7_decon.h
>>
>> diff --git a/Documentation/devicetree/bindings/video/exynos7-decon.txt
> b/Documentation/devicetree/bindings/video/exynos7-decon.txt
>> new file mode 100644
>> index 0000000..14db519
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/video/exynos7-decon.txt
>> @@ -0,0 +1,67 @@
>> +Device-Tree bindings for Samsung Exynos7 SoC display controller (DECON)
>> +
>> +DECON (Display and Enhancement Controller) is the Display Controller
> for the
>> +Exynos7 series of SoCs which transfers the image data from a video memory
>> +buffer to an external LCD interface.
>> +
>> +Required properties:
>> +- compatible: value should be "samsung,exynos7-decon";
>> +
>> +- reg: physical base address and length of the DECON registers set.
>> +
>> +- interrupt-parent: should be the phandle of the decon controller's
>> + parent interrupt controller.
>> +
>> +- interrupts: should contain a list of all DECON IP block interrupts
> in the
>> + order: FIFO Level, VSYNC, LCD_SYSTEM. The interrupt specifier
>> + format depends on the interrupt controller used.
>> +
>> +- interrupt-names: should contain the interrupt names: "fifo", "vsync",
>> + "lcd_sys", in the same order as they were listed in the interrupts
>> + property.
>> +
>> +- pinctrl-0: pin control group to be used for this controller.
>> +
>> +- pinctrl-names: must contain a "default" entry.
>> +
>> +- clocks: must include clock specifiers corresponding to entries in the
>> + clock-names property.
>> +
>> +- clock-names: list of clock names sorted in the same order as the clocks
>> + property. Must contain "pclk_decon0", "aclk_decon0",
>> + "decon0_eclk", "decon0_vclk".
>
> Should the DECON driver really care about decon0_eclk and decon0_vclk?
> If so then What is the purpose of these special clocks? I'm not sure
> that these clocks should be cared by driver. Until now, Exynos driver
> has cared about only video source and core source clocks.
>
> Can you give me more details about the use of the special clocks?
All these 4 clocks are definitely needed for the DECON to function properly.
pclk_decon0 and aclk_decon0 are clocks needed for normal
operation of DECON.
decon0_eclk and decon0_vclk are like pixel clocks.
The clock diagram is present in the Exynos7 user manual in clock
generation chapter.
>> +
>> +Optional Properties:
>> +- samsung,power-domain: a phandle to DECON power domain node.
>> +- display-timings: timing settings for FIMD, as described in document
> [1].
>> + Can be used in case timings cannot be provided otherwise
>> + or to override timings provided by the panel.
>> +
>> +[1]: Documentation/devicetree/bindings/video/display-timing.txt
>> +
>> +Example:
>> +
>> +SoC specific DT entry:
>> +
>> + decon@13930000 {
>> + compatible = "samsung,exynos7-decon";
>> + interrupt-parent = <&combiner>;
>> + reg = <0x13930000 0x1000>;
>> + interrupt-names = "lcd_sys", "vsync", "fifo";
>> + interrupts = <0 188 0>, <0 189 0>, <0 190 0>;
>> + clocks = <&clock_disp PCLK_DECON_INT>,
>> + <&clock_disp ACLK_DECON_INT>,
>> + <&clock_disp SCLK_DECON_INT_ECLK>,
>> + <&clock_disp SCLK_DECON_INT_EXTCLKPLL>;
>> + clock-names = "pclk_decon0", "aclk_decon0", "decon0_eclk",
>> + "decon0_vclk";
>> + status = "disabled";
>> + };
>> +
>> +Board specific DT entry:
>> +
>> + decon@13930000 {
>> + pinctrl-0 = <&lcd_clk &pwm1_out>;
>> + pinctrl-names = "default";
>> + status = "okay";
>> + };
>> diff --git a/drivers/gpu/drm/exynos/Kconfig
> b/drivers/gpu/drm/exynos/Kconfig
>> index 7f9f6f9..d3434cb 100644
>> --- a/drivers/gpu/drm/exynos/Kconfig
>> +++ b/drivers/gpu/drm/exynos/Kconfig
>> @@ -32,9 +32,16 @@ config DRM_EXYNOS_FIMD
>> help
>> Choose this option if you want to use Exynos FIMD for DRM.
>>
>> +config DRM_EXYNOS_DECON
>> + bool "Exynos DRM DECON"
>> + depends on DRM_EXYNOS
>> + select FB_MODE_HELPERS
>> + help
>> + Choose this option if you want to use Exynos DECON for DRM.
>> +
>> config DRM_EXYNOS_DPI
>> bool "EXYNOS DRM parallel output support"
>> - depends on DRM_EXYNOS_FIMD
>> + depends on (DRM_EXYNOS_FIMD || DRM_EXYNOS_DECON)
>> select DRM_PANEL
>> default n
>> help
>> @@ -42,7 +49,7 @@ config DRM_EXYNOS_DPI
>>
>> config DRM_EXYNOS_DSI
>> bool "EXYNOS DRM MIPI-DSI driver support"
>> - depends on DRM_EXYNOS_FIMD
>> + depends on (DRM_EXYNOS_FIMD || DRM_EXYNOS_DECON)
>> select DRM_MIPI_DSI
>> select DRM_PANEL
>> default n
>> @@ -51,7 +58,7 @@ config DRM_EXYNOS_DSI
>>
>> config DRM_EXYNOS_DP
>> bool "EXYNOS DRM DP driver support"
>> - depends on DRM_EXYNOS_FIMD && ARCH_EXYNOS && (DRM_PTN3460=n ||
> DRM_PTN3460=y || DRM_PTN3460=DRM_EXYNOS)
>> + depends on (DRM_EXYNOS_FIMD || DRM_EXYNOS_DECON) && ARCH_EXYNOS &&
> (DRM_PTN3460=n || DRM_PTN3460=y || DRM_PTN3460=DRM_EXYNOS)
>> default DRM_EXYNOS
>> select DRM_PANEL
>> help
>> diff --git a/drivers/gpu/drm/exynos/Makefile
> b/drivers/gpu/drm/exynos/Makefile
>> index 33ae365..d576587 100644
>> --- a/drivers/gpu/drm/exynos/Makefile
>> +++ b/drivers/gpu/drm/exynos/Makefile
>> @@ -11,6 +11,7 @@ exynosdrm-y := exynos_drm_drv.o exynos_drm_encoder.o \
>> exynosdrm-$(CONFIG_DRM_EXYNOS_IOMMU) += exynos_drm_iommu.o
>> exynosdrm-$(CONFIG_DRM_EXYNOS_DMABUF) += exynos_drm_dmabuf.o
>> exynosdrm-$(CONFIG_DRM_EXYNOS_FIMD) += exynos_drm_fimd.o
>> +exynosdrm-$(CONFIG_DRM_EXYNOS_DECON) += exynos7_drm_decon.o
>> exynosdrm-$(CONFIG_DRM_EXYNOS_DPI) += exynos_drm_dpi.o
>> exynosdrm-$(CONFIG_DRM_EXYNOS_DSI) += exynos_drm_dsi.o
>> exynosdrm-$(CONFIG_DRM_EXYNOS_DP) += exynos_dp_core.o exynos_dp_reg.o
>> diff --git a/drivers/gpu/drm/exynos/exynos7_drm_decon.c
> b/drivers/gpu/drm/exynos/exynos7_drm_decon.c
>> new file mode 100644
>> index 0000000..9d33a9a
>> --- /dev/null
>> +++ b/drivers/gpu/drm/exynos/exynos7_drm_decon.c
>> @@ -0,0 +1,1042 @@
>> +/* drivers/gpu/drm/exynos/exynos7_drm_decon.c
>> + *
>> + * Copyright (C) 2014 Samsung Electronics Co.Ltd
>> + * Authors:
>> + * Akshu Agarwal <akshua@xxxxxxxxx>
>> + * Ajay Kumar <ajaykumar.rs@xxxxxxxxxxx>
>> + *
>> + * This program is free software; you can redistribute it and/or
> modify it
>> + * under the terms of the GNU General Public License as published
> by the
>> + * Free Software Foundation; either version 2 of the License, or
> (at your
>> + * option) any later version.
>> + *
>> + */
>> +#include <drm/drmP.h>
>> +#include <drm/exynos_drm.h>
>> +
>> +#include <linux/clk.h>
>> +#include <linux/component.h>
>> +#include <linux/kernel.h>
>> +#include <linux/of.h>
>> +#include <linux/of_address.h>
>> +#include <linux/of_device.h>
>> +#include <linux/platform_device.h>
>> +#include <linux/pm_runtime.h>
>> +
>> +#include <video/of_display_timing.h>
>> +#include <video/of_videomode.h>
>> +#include <video/exynos7_decon.h>
>> +
>> +#include "exynos_drm_crtc.h"
>> +#include "exynos_drm_drv.h"
>> +#include "exynos_drm_fbdev.h"
>> +#include "exynos_drm_iommu.h"
>> +
>> +/*
>> + * DECON stands for Display and Enhancement controller, and
>> + * as a display controller, it transfers contents drawn on memory
>> + * to a LCD Panel through Display Interfaces such as RGB or
>> + * CPU Interface.
>
> DECON controller is more complex than FIMD. So can you leave
> descriptions enough?
Ok, I will just expand the acronym.
>> + */
>> +
>> +#define DECON_DEFAULT_FRAMERATE 60
>> +#define RESET_TIMEOUT 200
>
> Is there some guide - RESET_TIMEOUT is 200 - from HW guys?
No. I referred to an internal code which has fbdev
implementation for DECON. I modified it for drm.
I think we can remove RESET_TIMEOUT, because the moment
we write DECON_RESET, DECON gets reset. No need to wait.
>> +#define MIN_FB_WIDTH_FOR_16WORD_BURST 128
>> +
>> +#define WINDOWS_NR 2
>> +
>> +struct decon_win_data {
>> + unsigned int ovl_x;
>> + unsigned int ovl_y;
>> + unsigned int offset_x;
>> + unsigned int offset_y;
>> + unsigned int ovl_width;
>> + unsigned int ovl_height;
>> + unsigned int fb_width;
>> + unsigned int fb_height;
>> + unsigned int bpp;
>> + unsigned int pixel_format;
>> + dma_addr_t dma_addr;
>> + bool enabled;
>> + bool resume;
>> +};
>> +
>> +struct decon_context {
>> + struct exynos_drm_manager manager;
>> + struct device *dev;
>> + struct clk *pclk;
>> + struct clk *aclk;
>> + struct clk *eclk;
>> + struct clk *vclk;
>> + void __iomem *regs;
>> + struct drm_display_mode mode;
>> + struct decon_win_data win_data[WINDOWS_NR];
>> + unsigned int default_win;
>> + unsigned long irq_flags;
>> + bool suspended;
>> + wait_queue_head_t wait_vsync_queue;
>> + atomic_t wait_vsync_event;
>> +
>> + struct exynos_drm_panel_info panel;
>> + struct exynos_drm_display *display;
>> +};
>> +
>> +static inline struct decon_context *mgr_to_decon(struct
> exynos_drm_manager *mgr)
>> +{
>> + return container_of(mgr, struct decon_context, manager);
>> +}
>> +
>> +static const struct of_device_id decon_driver_dt_match[] = {
>> + { .compatible = "samsung,exynos7-decon"},
>> + {},
>> +};
>> +MODULE_DEVICE_TABLE(of, decon_driver_dt_match);
>> +
>> +static void decon_wait_for_vblank(struct exynos_drm_manager *mgr)
>> +{
>> + struct decon_context *ctx = mgr_to_decon(mgr);
>> +
>> + if (ctx->suspended)
>> + return;
>> +
>> + atomic_set(&ctx->wait_vsync_event, 1);
>> +
>> + /*
>> + * wait for decon to signal VSYNC interrupt or return after
>> + * timeout which is set to 50ms (refresh rate of 20).
>> + */
>> + if (!wait_event_timeout(ctx->wait_vsync_queue,
>> + !atomic_read(&ctx->wait_vsync_event),
>> + HZ/20))
>> + DRM_DEBUG_KMS("vblank wait timed out.\n");
>> +}
>> +
>> +static void decon_clear_channel(struct exynos_drm_manager *mgr)
>> +{
>> + struct decon_context *ctx = mgr_to_decon(mgr);
>> + int win, ch_enabled = 0;
>> +
>> + DRM_DEBUG_KMS("%s\n", __FILE__);
>> +
>> + /* Check if any channel is enabled. */
>> + for (win = 0; win < WINDOWS_NR; win++) {
>> + u32 val = readl(ctx->regs + WINCON(win));
>> +
>> + if (val & WINCONx_ENWIN) {
>> + val &= ~WINCONx_ENWIN;
>> + writel(val, ctx->regs + WINCON(win));
>> + ch_enabled = 1;
>> + }
>> + }
>> +
>> + /* Wait for vsync, as disable channel takes effect at next vsync */
>> + if (ch_enabled) {
>> + unsigned int state = ctx->suspended;
>> +
>> + ctx->suspended = 0;
>> + decon_wait_for_vblank(mgr);
>> + ctx->suspended = state;
>> + }
>> +}
>> +
>> +static int decon_mgr_initialize(struct exynos_drm_manager *mgr,
>> + struct drm_device *drm_dev)
>> +{
>> + struct decon_context *ctx = mgr_to_decon(mgr);
>> + struct exynos_drm_private *priv = drm_dev->dev_private;
>> + int ret;
>> +
>> + mgr->drm_dev = drm_dev;
>> + mgr->pipe = priv->pipe++;
>> +
>> + /* attach this sub driver to iommu mapping if supported. */
>> + if (is_drm_iommu_supported(mgr->drm_dev)) {
>> + /*
>> + * If any channel is already active, iommu will throw
>> + * a PAGE FAULT when enabled. So clear any channel if enabled.
>> + */
>> + decon_clear_channel(mgr);
>> +
>> + ret = drm_iommu_attach_device(mgr->drm_dev, ctx->dev);
>> + if (ret) {
>> + DRM_ERROR("drm_iommu_attach failed.\n");
>> + return ret;
>> + }
>> + }
>> +
>> + return 0;
>> +}
>> +
>> +static void decon_mgr_remove(struct exynos_drm_manager *mgr)
>> +{
>> + struct decon_context *ctx = mgr_to_decon(mgr);
>> +
>> + /* detach this sub driver from iommu mapping if supported. */
>> + if (is_drm_iommu_supported(mgr->drm_dev))
>> + drm_iommu_detach_device(mgr->drm_dev, ctx->dev);
>> +}
>> +
>> +static u32 decon_calc_clkdiv(struct decon_context *ctx,
>> + const struct drm_display_mode *mode)
>> +{
>> + unsigned long ideal_clk = mode->htotal * mode->vtotal * mode->vrefresh;
>> + u32 clkdiv;
>> +
>> + /* Find the clock divider value that gets us closest to ideal_clk */
>> + clkdiv = DIV_ROUND_UP(clk_get_rate(ctx->vclk), ideal_clk);
>> +
>> + return (clkdiv < 0x100) ? clkdiv : 0xff;
>> +}
>> +
>> +static bool decon_mode_fixup(struct exynos_drm_manager *mgr,
>> + const struct drm_display_mode *mode,
>> + struct drm_display_mode *adjusted_mode)
>> +{
>> + if (adjusted_mode->vrefresh == 0)
>> + adjusted_mode->vrefresh = DECON_DEFAULT_FRAMERATE;
>> +
>> + return true;
>> +}
>> +
>> +static void decon_mode_set(struct exynos_drm_manager *mgr,
>> + const struct drm_display_mode *in_mode)
>> +{
>> + struct decon_context *ctx = mgr_to_decon(mgr);
>> +
>> + drm_mode_copy(&ctx->mode, in_mode);
>> +}
>> +
>> +static void decon_commit(struct exynos_drm_manager *mgr)
>> +{
>> + struct decon_context *ctx = mgr_to_decon(mgr);
>> + struct drm_display_mode *mode = &ctx->mode;
>> + u32 val, clkdiv;
>> + int vsync_len, vbpd, vfpd, hsync_len, hbpd, hfpd;
>> +
>> + if (ctx->suspended)
>> + return;
>> +
>> + /* nothing to do if we haven't set the mode yet */
>> + if (mode->htotal == 0 || mode->vtotal == 0)
>> + return;
>> +
>> + /* setup vertical timing values. */
>> + vsync_len = mode->crtc_vsync_end - mode->crtc_vsync_start;
>> + vbpd = mode->crtc_vtotal - mode->crtc_vsync_end;
>> + vfpd = mode->crtc_vsync_start - mode->crtc_vdisplay;
>> +
>> + val = VIDTCON0_VBPD(vbpd - 1) | VIDTCON0_VFPD(vfpd - 1);
>> + writel(val, ctx->regs + VIDTCON0);
>> +
>> + val = VIDTCON1_VSPW(vsync_len - 1);
>> + writel(val, ctx->regs + VIDTCON1);
>> +
>> + /* setup horizontal timing values. */
>> + hsync_len = mode->crtc_hsync_end - mode->crtc_hsync_start;
>> + hbpd = mode->crtc_htotal - mode->crtc_hsync_end;
>> + hfpd = mode->crtc_hsync_start - mode->crtc_hdisplay;
>> +
>> + /* setup horizontal timing values. */
>> + val = VIDTCON2_HBPD(hbpd - 1) | VIDTCON2_HFPD(hfpd - 1);
>> + writel(val, ctx->regs + VIDTCON2);
>> +
>> + val = VIDTCON3_HSPW(hsync_len - 1);
>> + writel(val, ctx->regs + VIDTCON3);
>> +
>> + /* setup horizontal and vertical display size. */
>> + val = VIDTCON4_LINEVAL(mode->vdisplay - 1) |
>> + VIDTCON4_HOZVAL(mode->hdisplay - 1);
>> + writel(val, ctx->regs + VIDTCON4);
>> +
>> + writel(mode->vdisplay - 1, ctx->regs + LINECNT_OP_THRESHOLD);
>> +
>> + /*
>> + * fields of register with prefix '_F' would be updated
>> + * at vsync(same as dma start)
>> + */
>> + val = VIDCON0_ENVID | VIDCON0_ENVID_F;
>> + writel(val, ctx->regs + VIDCON0);
>> +
>> + clkdiv = decon_calc_clkdiv(ctx, mode);
>> + if (clkdiv > 1) {
>> + val = VCLKCON1_CLKVAL_NUM_VCLK(clkdiv - 1);
>> + writel(val, ctx->regs + VCLKCON1);
>> + writel(val, ctx->regs + VCLKCON2);
>> + }
>> +
>> + val = readl(ctx->regs + DECON_UPDATE);
>> + val |= DECON_UPDATE_STANDALONE_F;
>> + writel(val, ctx->regs + DECON_UPDATE);
>> +}
>> +
>> +static int decon_enable_vblank(struct exynos_drm_manager *mgr)
>> +{
>> + struct decon_context *ctx = mgr_to_decon(mgr);
>> + u32 val;
>> +
>> + if (ctx->suspended)
>> + return -EPERM;
>> +
>> + if (!test_and_set_bit(0, &ctx->irq_flags)) {
>> + val = readl(ctx->regs + VIDINTCON0);
>> +
>> + val |= VIDINTCON0_INT_ENABLE;
>> + val |= VIDINTCON0_INT_FRAME;
>> +
>> + val &= ~VIDINTCON0_FRAMESEL0_MASK;
>> + val |= VIDINTCON0_FRAMESEL0_VSYNC;
>> +
>> + writel(val, ctx->regs + VIDINTCON0);
>> + }
>> +
>> + return 0;
>> +}
>> +
>> +static void decon_disable_vblank(struct exynos_drm_manager *mgr)
>> +{
>> + struct decon_context *ctx = mgr_to_decon(mgr);
>> + u32 val;
>> +
>> + if (ctx->suspended)
>> + return;
>> +
>> + if (test_and_clear_bit(0, &ctx->irq_flags)) {
>> + val = readl(ctx->regs + VIDINTCON0);
>> +
>> + val &= ~VIDINTCON0_INT_ENABLE;
>> + val &= ~VIDINTCON0_INT_FRAME;
>> +
>> + writel(val, ctx->regs + VIDINTCON0);
>> + }
>> +}
>> +
>> +static void decon_win_mode_set(struct exynos_drm_manager *mgr,
>> + struct exynos_drm_overlay *overlay)
>> +{
>> + struct decon_context *ctx = mgr_to_decon(mgr);
>> + struct decon_win_data *win_data;
>> + int win, padding;
>> +
>> + if (!overlay) {
>> + DRM_ERROR("overlay is NULL\n");
>> + return;
>> + }
>> +
>> + win = overlay->zpos;
>> + if (win == DEFAULT_ZPOS)
>> + win = ctx->default_win;
>> +
>> + if (win < 0 || win >= WINDOWS_NR)
>> + return;
>> +
>> +
>> + win_data = &ctx->win_data[win];
>> +
>> + padding = (overlay->pitch / (overlay->bpp >> 3)) - overlay->fb_width;
>> + win_data->offset_x = overlay->fb_x;
>> + win_data->offset_y = overlay->fb_y;
>> + win_data->fb_width = overlay->fb_width + padding;
>> + win_data->fb_height = overlay->fb_height;
>> + win_data->ovl_x = overlay->crtc_x;
>> + win_data->ovl_y = overlay->crtc_y;
>> + win_data->ovl_width = overlay->crtc_width;
>> + win_data->ovl_height = overlay->crtc_height;
>> + win_data->dma_addr = overlay->dma_addr[0];
>> + win_data->bpp = overlay->bpp;
>> + win_data->pixel_format = overlay->pixel_format;
>> +
>> + DRM_DEBUG_KMS("offset_x = %d, offset_y = %d\n",
>> + win_data->offset_x, win_data->offset_y);
>> + DRM_DEBUG_KMS("ovl_width = %d, ovl_height = %d\n",
>> + win_data->ovl_width, win_data->ovl_height);
>> + DRM_DEBUG_KMS("paddr = 0x%lx\n", (unsigned long)win_data->dma_addr);
>> + DRM_DEBUG_KMS("fb_width = %d, crtc_width = %d\n",
>> + overlay->fb_width, overlay->crtc_width);
>> +}
>> +
>> +static void decon_win_set_pixfmt(struct decon_context *ctx, unsigned
> int win)
>> +{
>> + struct decon_win_data *win_data = &ctx->win_data[win];
>> + unsigned long val;
>> +
>> + val = readl(ctx->regs + WINCON(win));
>> + val &= ~WINCONx_BPPMODE_MASK;
>> +
>> + switch (win_data->pixel_format) {
>> + case DRM_FORMAT_RGB565:
>> + val |= WINCONx_BPPMODE_16BPP_565;
>> + val |= WINCONx_BURSTLEN_16WORD;
>> + break;
>> + case DRM_FORMAT_XRGB8888:
>> + val |= WINCONx_BPPMODE_24BPP_xRGB;
>> + val |= WINCONx_BURSTLEN_16WORD;
>> + break;
>> + case DRM_FORMAT_XBGR8888:
>> + val |= WINCONx_BPPMODE_24BPP_xBGR;
>> + val |= WINCONx_BURSTLEN_16WORD;
>> + break;
>> + case DRM_FORMAT_RGBX8888:
>> + val |= WINCONx_BPPMODE_24BPP_RGBx;
>> + val |= WINCONx_BURSTLEN_16WORD;
>> + break;
>> + case DRM_FORMAT_BGRX8888:
>> + val |= WINCONx_BPPMODE_24BPP_BGRx;
>> + val |= WINCONx_BURSTLEN_16WORD;
>> + break;
>> + case DRM_FORMAT_ARGB8888:
>> + val |= WINCONx_BPPMODE_32BPP_ARGB | WINCONx_BLD_PIX |
>> + WINCONx_ALPHA_SEL;
>> + val |= WINCONx_BURSTLEN_16WORD;
>> + break;
>> + case DRM_FORMAT_ABGR8888:
>> + val |= WINCONx_BPPMODE_32BPP_ABGR | WINCONx_BLD_PIX |
>> + WINCONx_ALPHA_SEL;
>> + val |= WINCONx_BURSTLEN_16WORD;
>> + break;
>> + case DRM_FORMAT_RGBA8888:
>> + val |= WINCONx_BPPMODE_32BPP_RGBA | WINCONx_BLD_PIX |
>> + WINCONx_ALPHA_SEL;
>> + val |= WINCONx_BURSTLEN_16WORD;
>> + break;
>> + case DRM_FORMAT_BGRA8888:
>> + val |= WINCONx_BPPMODE_32BPP_BGRA | WINCONx_BLD_PIX |
>> + WINCONx_ALPHA_SEL;
>> + val |= WINCONx_BURSTLEN_16WORD;
>> + break;
>> + default:
>> + DRM_DEBUG_KMS("invalid pixel size so using unpacked 24bpp.\n");
>> +
>> + val |= WINCONx_BPPMODE_24BPP_xRGB;
>> + val |= WINCONx_BURSTLEN_16WORD;
>> + break;
>> + }
>> +
>> + DRM_DEBUG_KMS("bpp = %d\n", win_data->bpp);
>> +
>> + /*
>> + * In case of exynos, setting dma-burst to 16Word causes permanent
>> + * tearing for very small buffers, e.g. cursor buffer. Burst Mode
>> + * switching which is based on overlay size is not recommended as
>> + * overlay size varies a lot towards the end of the screen and rapid
>> + * movement causes unstable DMA which results into iommu crash/tear.
>> + */
>> +
>> + if (win_data->fb_width < MIN_FB_WIDTH_FOR_16WORD_BURST) {
>> + val &= ~WINCONx_BURSTLEN_MASK;
>> + val |= WINCONx_BURSTLEN_8WORD;
>> + }
>> +
>> + writel(val, ctx->regs + WINCON(win));
>> +}
>> +
>> +static void decon_win_set_colkey(struct decon_context *ctx, unsigned
> int win)
>> +{
>> + unsigned int keycon0 = 0, keycon1 = 0;
>> +
>> + keycon0 = ~(WxKEYCON0_KEYBL_EN | WxKEYCON0_KEYEN_F |
>> + WxKEYCON0_DIRCON) | WxKEYCON0_COMPKEY(0);
>> +
>> + keycon1 = WxKEYCON1_COLVAL(0xffffffff);
>> +
>> + writel(keycon0, ctx->regs + WKEYCON0_BASE(win));
>> + writel(keycon1, ctx->regs + WKEYCON1_BASE(win));
>> +}
>> +
>> +/**
>> + * shadow_protect_win() - disable updating values from shadow
> registers at vsync
>> + *
>> + * @win: window to protect registers for
>> + * @protect: 1 to protect (disable updates)
>> + */
>> +static void decon_shadow_protect_win(struct decon_context *ctx,
>> + int win, bool protect)
>> +{
>> + u32 bits, val;
>> +
>> + bits = SHADOWCON_WINx_PROTECT(win);
>> +
>> + val = readl(ctx->regs + SHADOWCON);
>> + if (protect)
>> + val |= bits;
>> + else
>> + val &= ~bits;
>> + writel(val, ctx->regs + SHADOWCON);
>> +}
>> +
>> +static void decon_win_commit(struct exynos_drm_manager *mgr, int zpos)
>> +{
>> + struct decon_context *ctx = mgr_to_decon(mgr);
>> + struct decon_win_data *win_data;
>> + int win = zpos;
>> + unsigned long val, alpha, blendeq;
>> + unsigned int last_x;
>> + unsigned int last_y;
>> +
>> + if (ctx->suspended)
>> + return;
>> +
>> + if (win == DEFAULT_ZPOS)
>> + win = ctx->default_win;
>> +
>> + if (win < 0 || win >= WINDOWS_NR)
>> + return;
>> +
>> + win_data = &ctx->win_data[win];
>> +
>> + /* If suspended, enable this on resume */
>> + if (ctx->suspended) {
>> + win_data->resume = true;
>> + return;
>> + }
>> +
>> + /*
>> + * SHADOWCON/PRTCON register is used for enabling timing.
>> + *
>> + * for example, once only width value of a register is set,
>> + * if the dma is started then decon hardware could malfunction so
>> + * with protect window setting, the register fields with prefix '_F'
>> + * wouldn't be updated at vsync also but updated once unprotect window
>> + * is set.
>> + */
>> +
>> + /* protect windows */
>> + decon_shadow_protect_win(ctx, win, true);
>> +
>> + /* buffer start address */
>> + val = (unsigned long)win_data->dma_addr;
>> + writel(val, ctx->regs + VIDW_BUF_START(win));
>> +
>> + /* buffer size */
>> + writel(win_data->fb_width, ctx->regs + VIDW_WHOLE_X(win));
>> + writel(win_data->fb_height, ctx->regs + VIDW_WHOLE_Y(win));
>> +
>> + /* offset from the start of the buffer to read */
>> + writel(win_data->offset_x, ctx->regs + VIDW_OFFSET_X(win));
>> + writel(win_data->offset_y, ctx->regs + VIDW_OFFSET_Y(win));
>> +
>> + DRM_DEBUG_KMS("start addr = 0x%lx\n",
>> + (unsigned long)win_data->dma_addr);
>> + DRM_DEBUG_KMS("ovl_width = %d, ovl_height = %d\n",
>> + win_data->ovl_width, win_data->ovl_height);
>> +
>> + /* OSD position */
>> + val = VIDOSDxA_TOPLEFT_X(win_data->ovl_x) |
>> + VIDOSDxA_TOPLEFT_Y(win_data->ovl_y);
>> + writel(val, ctx->regs + VIDOSD_A(win));
>> +
>> + last_x = win_data->ovl_x + win_data->ovl_width;
>> + if (last_x)
>> + last_x--;
>> + last_y = win_data->ovl_y + win_data->ovl_height;
>> + if (last_y)
>> + last_y--;
>> +
>> + val = VIDOSDxB_BOTRIGHT_X(last_x) | VIDOSDxB_BOTRIGHT_Y(last_y);
>> +
>> + writel(val, ctx->regs + VIDOSD_B(win));
>> +
>> + DRM_DEBUG_KMS("osd pos: tx = %d, ty = %d, bx = %d, by = %d\n",
>> + win_data->ovl_x, win_data->ovl_y, last_x, last_y);
>> +
>> + /* OSD alpha */
>> + alpha = VIDOSDxC_ALPHA0_R_F(0x0) |
>> + VIDOSDxC_ALPHA0_G_F(0x0) |
>> + VIDOSDxC_ALPHA0_B_F(0x0);
>> +
>> + writel(alpha, ctx->regs + VIDOSD_C(win));
>> +
>> + alpha = VIDOSDxD_ALPHA1_R_F(0xff) |
>> + VIDOSDxD_ALPHA1_G_F(0xff) |
>> + VIDOSDxD_ALPHA1_B_F(0xff);
>> +
>> + writel(alpha, ctx->regs + VIDOSD_D(win));
>> +
>> + if (win != 0) {
>> + blendeq = BLENDE_A_FUNC(BLENDE_COEF_ONE) |
>> + BLENDE_B_FUNC(BLENDE_COEF_ZERO) |
>> + BLENDE_P_FUNC(BLENDE_COEF_ZERO) |
>> + BLENDE_Q_FUNC(BLENDE_COEF_ZERO);
>> +
>> + writel(blendeq, ctx->regs + BLENDE(win - 1));
>> + }
>> +
>> + decon_win_set_pixfmt(ctx, win);
>> +
>> + /* hardware window 0 doesn't support color key. */
>> + if (win != 0)
>> + decon_win_set_colkey(ctx, win);
>> +
>> + /* wincon */
>> + val = readl(ctx->regs + WINCON(win));
>> + val |= WINCONx_TRIPLE_BUF_MODE;
>> + val |= WINCONx_ENWIN;
>> + writel(val, ctx->regs + WINCON(win));
>> +
>> + /* Enable DMA channel and unprotect windows */
>> + decon_shadow_protect_win(ctx, win, false);
>> +
>> + val = readl(ctx->regs + DECON_UPDATE);
>> + val |= DECON_UPDATE_STANDALONE_F;
>> + writel(val, ctx->regs + DECON_UPDATE);
>> +
>> + win_data->enabled = true;
>> +}
>> +
>> +static void decon_win_disable(struct exynos_drm_manager *mgr, int zpos)
>> +{
>> + struct decon_context *ctx = mgr_to_decon(mgr);
>> + struct decon_win_data *win_data;
>> + int win = zpos;
>> + u32 val;
>> +
>> + if (win == DEFAULT_ZPOS)
>> + win = ctx->default_win;
>> +
>> + if (win < 0 || win >= WINDOWS_NR)
>> + return;
>> +
>> + win_data = &ctx->win_data[win];
>> +
>> + if (ctx->suspended) {
>> + /* do not resume this window*/
>> + win_data->resume = false;
>> + return;
>> + }
>> +
>> + /* protect windows */
>> + decon_shadow_protect_win(ctx, win, true);
>> +
>> + /* wincon */
>> + val = readl(ctx->regs + WINCON(win));
>> + val &= ~WINCONx_ENWIN;
>> + writel(val, ctx->regs + WINCON(win));
>> +
>> + decon_shadow_protect_win(ctx, win, false);
>> +
>> + win_data->enabled = false;
>> +}
>> +
>> +static void decon_window_suspend(struct exynos_drm_manager *mgr)
>> +{
>> + struct decon_context *ctx = mgr_to_decon(mgr);
>> + struct decon_win_data *win_data;
>> + int i;
>> +
>> + for (i = 0; i < WINDOWS_NR; i++) {
>> + win_data = &ctx->win_data[i];
>> + win_data->resume = win_data->enabled;
>> + if (win_data->enabled)
>> + decon_win_disable(mgr, i);
>> + }
>> +}
>> +
>> +static void decon_window_resume(struct exynos_drm_manager *mgr)
>> +{
>> + struct decon_context *ctx = mgr_to_decon(mgr);
>> + struct decon_win_data *win_data;
>> + int i;
>> +
>> + for (i = 0; i < WINDOWS_NR; i++) {
>> + win_data = &ctx->win_data[i];
>> + win_data->enabled = win_data->resume;
>> + win_data->resume = false;
>> + }
>> +}
>> +
>> +static void decon_apply(struct exynos_drm_manager *mgr)
>> +{
>> + struct decon_context *ctx = mgr_to_decon(mgr);
>> + struct decon_win_data *win_data;
>> + int i;
>> +
>> + for (i = 0; i < WINDOWS_NR; i++) {
>> + win_data = &ctx->win_data[i];
>> + if (win_data->enabled)
>> + decon_win_commit(mgr, i);
>> + else
>> + decon_win_disable(mgr, i);
>> + }
>> +
>> + decon_commit(mgr);
>> +}
>> +
>> +static int decon_reg_reset(struct decon_context *ctx)
>> +{
>> + int tries = RESET_TIMEOUT;
>> +
>> + writel(VIDCON0_SWRESET, ctx->regs + VIDCON0);
>> +
>> + while (tries) {
>> + if (!(readl(ctx->regs + VIDCON0) & VIDCON0_SWRESET))
>> + break;
>> + udelay(10);
>> + tries--;
>> + }
>> +
>> + if (!tries) {
>> + DRM_ERROR("Failed to reset decon\n");
>> + return -EBUSY;
>> + }
>> +
>> + return 0;
>> +}
>> +
>> +static void decon_cmu_enable(struct decon_context *ctx)
>> +{
>> + writel(~DECON_CMU_ALL_CLKGATE_ENABLE, ctx->regs + DECON_CMU);
>
> This function says it enables all clock gates but actually, it disables
> them. And please flag real fields: [31:2] are reserved.
I tried removing this piece of code, and things still work fine.
>> +}
>> +
>> +static void decon_blend_alpha_bits(struct decon_context *ctx)
>> +{
>> + writel(BLENDCON_NEW_8BIT_ALPHA_VALUE, ctx->regs + BLENDCON);
>> +}
>> +
>> +static void decon_set_vidout(struct decon_context *ctx)
>> +{
>> + writel(VIDOUTCON0_LCD_ON | VIDOUTCON0_RGBIF, ctx->regs + VIDOUTCON0);
>
> VIDOUTCON0_LCD_ON is not right mean. Please use VIDOUTCON0_DUAL_F instead.
Ok, I will use VIDOUTCON0_DUAL_F.
> And you forces to set video interface to RGB IF. So please set also it
> correctly through dt binding.
Yes, I should check for i80-if-timings node and set video mode if node
not present.
>
>> +}
>> +
>> +static void decon_set_crc(struct decon_context *ctx)
>> +{
>> + u32 val = readl(ctx->regs + CRCCTRL);
>> +
>> + writel(val & ~(CRCCTRL_CRCCLKEN | CRCCTRL_CRCEN | CRCCTRL_CRCSTART_F),
>> + ctx->regs + CRCCTRL);
>
> What is the purpose of CRCCLK? And why do you set all fields of this
> register like above?
I just took it from the internal code. I tried removing this piece of code, and
things still work fine. So, I will remove this as of now.
>> +}
>> +
>> +static void decon_set_clkval(struct decon_context *ctx)
>> +{
>> + writel(VCLKCON0_CLKVALUP | VCLKCON0_VCLKFREE, ctx->regs + VCLKCON0);
>> +}
>> +
>> +static void decon_set_fixvclk(struct decon_context *ctx)
>> +{
>> + writel(VIDCON1_VCLK_HOLD, ctx->regs + VIDCON1(0));
>> +}
>> +
>> +static int decon_poweron(struct exynos_drm_manager *mgr)
>> +{
>> + struct decon_context *ctx = mgr_to_decon(mgr);
>> + int ret;
>> +
>> + if (!ctx->suspended)
>> + return 0;
>> +
>> + ctx->suspended = false;
>> +
>> + pm_runtime_get_sync(ctx->dev);
>> +
>> + ret = clk_prepare_enable(ctx->pclk);
>> + if (ret < 0) {
>> + DRM_ERROR("Failed to prepare_enable the pclk [%d]\n", ret);
>> + goto pclk_err;
>> + }
>> +
>> + ret = clk_prepare_enable(ctx->aclk);
>> + if (ret < 0) {
>> + DRM_ERROR("Failed to prepare_enable the aclk [%d]\n", ret);
>> + goto aclk_err;
>> + }
>> +
>> + ret = clk_prepare_enable(ctx->eclk);
>> + if (ret < 0) {
>> + DRM_ERROR("Failed to prepare_enable the eclk [%d]\n", ret);
>> + goto eclk_err;
>> + }
>> +
>> + ret = clk_prepare_enable(ctx->vclk);
>> + if (ret < 0) {
>> + DRM_ERROR("Failed to prepare_enable the vclk [%d]\n", ret);
>> + goto vclk_err;
>> + }
>> +
>> + ret = decon_reg_reset(ctx);
>
> Why is register reset needed at here?
Well, this is needed in case the bootloader has already set DECON!
>> + if (ret < 0) {
>> + DRM_ERROR("Failed to reset decon [%d]\n", ret);
>> + goto err;
>> + }
>> +
>> + decon_cmu_enable(ctx);
>> + decon_blend_alpha_bits(ctx);
>> + decon_set_vidout(ctx);
>> + decon_set_crc(ctx);
>> + decon_set_fixvclk(ctx);
>> + decon_set_clkval(ctx);
>
> Should above funtions really be called in power_on? I think most of
> above functions can be called in decon_commit funtion and it can write a
> register directly instead of using function.
Don't you think its better to write these registers here, than writing these
registers in decon_commit?
Because, none of these registers depend on the LCD timing or window mode.
>> +
>> + /* if vblank was enabled status, enable it again. */
>> + if (test_and_clear_bit(0, &ctx->irq_flags)) {
>> + ret = decon_enable_vblank(mgr);
>> + if (ret) {
>> + DRM_ERROR("Failed to re-enable vblank [%d]\n", ret);
>> + goto err;
>> + }
>> + }
>> +
>> + decon_window_resume(mgr);
>> +
>> + decon_apply(mgr);
>> +
>> + return 0;
>> +
>> +err:
>> + clk_disable_unprepare(ctx->vclk);
>> +vclk_err:
>> + clk_disable_unprepare(ctx->eclk);
>> +eclk_err:
>> + clk_disable_unprepare(ctx->aclk);
>> +aclk_err:
>> + clk_disable_unprepare(ctx->pclk);
>> +pclk_err:
>> + ctx->suspended = true;
>> + return ret;
>> +}
>> +
>> +static int decon_poweroff(struct exynos_drm_manager *mgr)
>> +{
>> + struct decon_context *ctx = mgr_to_decon(mgr);
>> +
>> + if (ctx->suspended)
>> + return 0;
>> +
>> + /*
>> + * We need to make sure that all windows are disabled before we
>> + * suspend that connector. Otherwise we might try to scan from
>> + * a destroyed buffer later.
>> + */
>> + decon_window_suspend(mgr);
>> +
>> + clk_disable_unprepare(ctx->vclk);
>> + clk_disable_unprepare(ctx->eclk);
>> + clk_disable_unprepare(ctx->aclk);
>> + clk_disable_unprepare(ctx->pclk);
>> +
>> + pm_runtime_put_sync(ctx->dev);
>> +
>> + ctx->suspended = true;
>> + return 0;
>> +}
>> +
>> +static void decon_dpms(struct exynos_drm_manager *mgr, int mode)
>> +{
>> + DRM_DEBUG_KMS("%s, %d\n", __FILE__, mode);
>> +
>> + switch (mode) {
>> + case DRM_MODE_DPMS_ON:
>> + decon_poweron(mgr);
>> + break;
>> + case DRM_MODE_DPMS_STANDBY:
>> + case DRM_MODE_DPMS_SUSPEND:
>> + case DRM_MODE_DPMS_OFF:
>> + decon_poweroff(mgr);
>> + break;
>> + default:
>> + DRM_DEBUG_KMS("unspecified mode %d\n", mode);
>> + break;
>> + }
>> +}
>> +
>> +static struct exynos_drm_manager_ops decon_manager_ops = {
>> + .dpms = decon_dpms,
>> + .mode_fixup = decon_mode_fixup,
>> + .mode_set = decon_mode_set,
>> + .commit = decon_commit,
>> + .enable_vblank = decon_enable_vblank,
>> + .disable_vblank = decon_disable_vblank,
>> + .wait_for_vblank = decon_wait_for_vblank,
>> + .win_mode_set = decon_win_mode_set,
>> + .win_commit = decon_win_commit,
>> + .win_disable = decon_win_disable,
>> +};
>> +
>> +
>> +static irqreturn_t decon_irq_handler(int irq, void *dev_id)
>> +{
>> + struct decon_context *ctx = (struct decon_context *)dev_id;
>> + u32 val;
>> +
>> + val = readl(ctx->regs + VIDINTCON1);
>> +
>> + if (val & VIDINTCON1_INT_FRAME)
>> + /* VSYNC interrupt */
>> + writel(VIDINTCON1_INT_FRAME, ctx->regs + VIDINTCON1);
>> +
>> + /* check the crtc is detached already from encoder */
>> + if (ctx->manager.pipe < 0 || !ctx->manager.drm_dev)
>> + goto out;
>> +
>> + drm_handle_vblank(ctx->manager.drm_dev, ctx->manager.pipe);
>> + exynos_drm_crtc_finish_pageflip(ctx->manager.drm_dev,
>> + ctx->manager.pipe);
>> +
>> + /* set wait vsync event to zero and wake up queue. */
>> + if (atomic_read(&ctx->wait_vsync_event)) {
>> + atomic_set(&ctx->wait_vsync_event, 0);
>> + wake_up(&ctx->wait_vsync_queue);
>> + }
>> +out:
>> + return IRQ_HANDLED;
>> +}
>> +
>> +static int decon_bind(struct device *dev, struct device *master, void
> *data)
>> +{
>> + struct decon_context *ctx = dev_get_drvdata(dev);
>> + struct drm_device *drm_dev = data;
>> + int ret;
>> +
>> + ret = decon_mgr_initialize(&ctx->manager, drm_dev);
>> + if (ret) {
>> + DRM_ERROR("decon_mgr_initialize failed.\n");
>> + return ret;
>> + }
>> +
>> + exynos_drm_crtc_create(&ctx->manager);
>> + if (ctx->display)
>> + exynos_drm_create_enc_conn(drm_dev, ctx->display);
>> +
>> + return 0;
>> +
>> +}
>> +
>> +static void decon_unbind(struct device *dev, struct device *master,
>> + void *data)
>> +{
>> + struct decon_context *ctx = dev_get_drvdata(dev);
>> +
>> + decon_dpms(&ctx->manager, DRM_MODE_DPMS_OFF);
>> +
>> + if (ctx->display)
>> + exynos_dpi_remove(ctx->display);
>> +
>> + decon_mgr_remove(&ctx->manager);
>> +}
>> +
>> +static const struct component_ops decon_component_ops = {
>> + .bind = decon_bind,
>> + .unbind = decon_unbind,
>> +};
>> +
>> +static int decon_probe(struct platform_device *pdev)
>> +{
>> + struct device *dev = &pdev->dev;
>> + struct decon_context *ctx;
>> + struct resource *res;
>> + int ret = -EINVAL;
>> +
>> + if (!dev->of_node)
>> + return -ENODEV;
>> +
>> + ctx = devm_kzalloc(dev, sizeof(*ctx), GFP_KERNEL);
>> + if (!ctx)
>> + return -ENOMEM;
>> +
>> + ctx->manager.type = EXYNOS_DISPLAY_TYPE_LCD;
>> + ctx->manager.ops = &decon_manager_ops;
>> +
>> + ret = exynos_drm_component_add(dev, EXYNOS_DEVICE_TYPE_CRTC,
>> + ctx->manager.type);
>> + if (ret)
>> + return ret;
>> +
>> + ctx->dev = dev;
>> + ctx->suspended = true;
>> +
>> + ctx->regs = of_iomap(dev->of_node, 0);
>> + if (IS_ERR(ctx->regs)) {
>> + ret = PTR_ERR(ctx->regs);
>> + goto err_del_component;
>> + }
>> +
>> + ctx->pclk = devm_clk_get(dev, "pclk_decon0");
>> + if (IS_ERR(ctx->pclk)) {
>> + dev_err(dev, "failed to get bus clock pclk\n");
>> + ret = PTR_ERR(ctx->pclk);
>> + goto err_iounmap;
>> + }
>> +
>> + ctx->aclk = devm_clk_get(dev, "aclk_decon0");
>> + if (IS_ERR(ctx->aclk)) {
>> + dev_err(dev, "failed to get bus clock aclk\n");
>> + ret = PTR_ERR(ctx->aclk);
>> + goto err_iounmap;
>> + }
>> +
>> + ctx->eclk = devm_clk_get(dev, "decon0_eclk");
>> + if (IS_ERR(ctx->eclk)) {
>> + dev_err(dev, "failed to get eclock\n");
>> + ret = PTR_ERR(ctx->eclk);
>> + goto err_iounmap;
>> + }
>> +
>> + ctx->vclk = devm_clk_get(dev, "decon0_vclk");
>> + if (IS_ERR(ctx->vclk)) {
>> + dev_err(dev, "failed to get vclock\n");
>> + ret = PTR_ERR(ctx->vclk);
>> + goto err_iounmap;
>> + }
>> +
>> + res = platform_get_resource_byname(pdev, IORESOURCE_IRQ, "vsync");
>
> lcd_sys irq can be used according to video interface.
>
>> + if (!res) {
>> + dev_err(dev, "irq request failed.\n");
>> + ret = -ENXIO;
>> + goto err_iounmap;
>> + }
>> +
>> + ret = devm_request_irq(dev, res->start, decon_irq_handler,
>> + 0, "drm_decon", ctx);
>> + if (ret) {
>> + dev_err(dev, "irq request failed.\n");
>> + goto err_iounmap;
>> + }
>> +
>> + init_waitqueue_head(&ctx->wait_vsync_queue);
>> + atomic_set(&ctx->wait_vsync_event, 0);
>> +
>> + platform_set_drvdata(pdev, ctx);
>> +
>> + ctx->display = exynos_dpi_probe(dev);
>> + if (IS_ERR(ctx->display)) {
>> + ret = PTR_ERR(ctx->display);
>> + goto err_iounmap;
>> + }
>> +
>> + pm_runtime_enable(dev);
>> +
>> + ret = component_add(dev, &decon_component_ops);
>> + if (ret)
>> + goto err_disable_pm_runtime;
>> +
>> + return ret;
>> +
>> +err_disable_pm_runtime:
>> + pm_runtime_disable(dev);
>> +
>> +err_iounmap:
>> + iounmap(ctx->regs);
>> +
>> +err_del_component:
>> + exynos_drm_component_del(dev, EXYNOS_DEVICE_TYPE_CRTC);
>> + return ret;
>> +}
>> +
>> +static int decon_remove(struct platform_device *pdev)
>> +{
>> + struct decon_context *ctx = dev_get_drvdata(&pdev->dev);
>> +
>> + pm_runtime_disable(&pdev->dev);
>> +
>> + iounmap(ctx->regs);
>> +
>> + component_del(&pdev->dev, &decon_component_ops);
>> + exynos_drm_component_del(&pdev->dev, EXYNOS_DEVICE_TYPE_CRTC);
>> +
>> + return 0;
>> +}
>> +
>> +struct platform_driver decon_driver = {
>> + .probe = decon_probe,
>> + .remove = decon_remove,
>> + .driver = {
>> + .name = "exynos-decon",
>> + .of_match_table = decon_driver_dt_match,
>> + },
>> +};
Regards,
Ajay Kumar
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel
