On Wed, Feb 04, 2015 at 11:30:23AM +0900, Joonyoung Shim wrote: > +Cc Inki, > > Hi, > > On 02/04/2015 12:48 AM, Daniel Vetter wrote: > > So this has been merged originally in > > > > commit 83052d4d5cd518332440bb4ee63d68bb5f744e0f > > Author: Seung-Woo Kim <sw0312.kim@xxxxxxxxxxx> > > Date: Thu Dec 15 15:40:55 2011 +0900 > > > > drm: Add multi buffer plane pixel formats > > > > which hasn't seen a lot of review really. The problem is that it's not > > a real pixel format, but just a different way to lay out NV12 pixels > > in macroblocks, i.e. a tiling format. > > > > The new way of doing this is with the soon-to-be-merge fb modifiers. > > > > This was brough up in some long irc discussion around the entire > > topic, as an example of where things have gone wrong. Luckily we can > > correct the mistake: > > - The kms side support for NV12MT is all dead code because > > format_check in drm_crtc.c never accepted NV12MT. > > So it was tried to support NV12MT in format_check. I really welcome the > new way. Yeah, the new way should also make sharing buffers between devices easier since we'll have a fairly rigid standard about things. On irc we've discussed that we probably need a VENDOR_MPEG modifier range so that we can have cross-chip-vendor standardized modifiers for the various macroblock tiling layouts seen in video streams (64x32, 16x16). > Acked-by: Joonyoung Shim <jy0922.shim@xxxxxxxxxxx> Thanks, I've picked the patch up into my drm-misc branch. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
