2015-02-03 Daniel Vetter <daniel.vetter@xxxxxxxx>: > So this has been merged originally in > > commit 83052d4d5cd518332440bb4ee63d68bb5f744e0f > Author: Seung-Woo Kim <sw0312.kim@xxxxxxxxxxx> > Date: Thu Dec 15 15:40:55 2011 +0900 > > drm: Add multi buffer plane pixel formats > > which hasn't seen a lot of review really. The problem is that it's not > a real pixel format, but just a different way to lay out NV12 pixels > in macroblocks, i.e. a tiling format. > > The new way of doing this is with the soon-to-be-merge fb modifiers. > > This was brough up in some long irc discussion around the entire > topic, as an example of where things have gone wrong. Luckily we can > correct the mistake: > - The kms side support for NV12MT is all dead code because > format_check in drm_crtc.c never accepted NV12MT. > - The gem side for the gsc support doesn't look better: The code > forgets to set the pixel format and makes a big mess with the tiling > mode bits, inadvertedly setting them all. > > Conclusion: This never really worked (at least not in upstream) and > hence we can savely correct our mistake here. > > Cc: Seung-Woo Kim <sw0312.kim@xxxxxxxxxxx> > Cc: Inki Dae <inki.dae@xxxxxxxxxxx> > Cc: Kyungmin Park <kyungmin.park@xxxxxxxxxxx> > Cc: Rob Clark <robclark@xxxxxxxxxxxxxxx> > Cc: Daniel Stone <daniel@xxxxxxxxxxxxx> > Cc: Damien Lespiau <damien.lespiau@xxxxxxxxx> > Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxxx> > --- > drivers/gpu/drm/exynos/exynos_drm_fimc.c | 14 ++------------ > drivers/gpu/drm/exynos/exynos_drm_gsc.c | 6 ------ > drivers/gpu/drm/exynos/exynos_drm_plane.c | 1 - > drivers/gpu/drm/exynos/exynos_mixer.c | 2 -- > include/uapi/drm/drm_fourcc.h | 3 --- > 5 files changed, 2 insertions(+), 24 deletions(-) That seems good to me. Reviewed-by: Gustavo Padovan <gustavo.padovan@xxxxxxxxxxxxxxx> Gustavo _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
