2015-02-02 Joonyoung Shim <jy0922.shim@xxxxxxxxxxx>: > Hi, > > On 01/30/2015 11:44 PM, Gustavo Padovan wrote: > > Hi Joonyoung, > > > > 2015-01-30 Joonyoung Shim <jy0922.shim@xxxxxxxxxxx>: > > > >> Hi, > >> > >> On 01/23/2015 09:43 PM, Gustavo Padovan wrote: > >>> From: Daniel Kurtz <djkurtz@xxxxxxxxxxxx> > >>> > >>> The 'mode' is the modeline information which specifies the ideal mode > >>> requested by the mode set initiator (usually userspace). > >>> The 'adjusted_mode' is the actual hardware mode after all the crtcs > >>> and encoders have had a chance to "fix it up". > >>> > >>> The adjusted_mode starts as a duplicate of the mode in > >>> drm_crtc_helper_set_mode(), and gets modified as required. There is no > >>> reason to touch the original requested mode. > >>> > >> > >> Agree, but is there any side effect after this commit? Should we save > >> adjusted_mode to other variable and use it? > > > > I haven't seen any. Tested on peach pi and snow. Do we have any reason to save > > it now? I don't we have a user for it now. > > > > Because current codes use values of adjusted_mode in exynos drm hw drivers. I fail to see where this happen. adjusted_mode is passed to to the mode_set() callback and drivers can use it from there as the hdmi one does for example. Gustavo _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
