On Fri, Jan 30, 2015 at 06:28:59AM -0500, Yakir Yang wrote: > Signed-off-by: Yakir Yang <ykk@xxxxxxxxxxxxxx> > --- > Changes in v2: > - Add suspend/resume support for dw_hdmi_rockchip driver > > drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c b/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c > index d236faa..2f8bacb 100644 > --- a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c > +++ b/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c > @@ -323,9 +323,22 @@ static int dw_hdmi_rockchip_remove(struct platform_device *pdev) > return 0; > } > > +static int dw_hdmi_rockchip_suspend(struct platform_device *pdev, > + pm_message_t state) > +{ > + return dw_hdmi_suspend(pdev, state); > +} > + > +static int dw_hdmi_rockchip_resume(struct platform_device *pdev) > +{ > + return dw_hdmi_resume(pdev); > +} > + > static struct platform_driver dw_hdmi_rockchip_pltfm_driver = { > .probe = dw_hdmi_rockchip_probe, > .remove = dw_hdmi_rockchip_remove, > + .resume = dw_hdmi_rockchip_resume, > + .suspend = dw_hdmi_rockchip_suspend, > .driver = { > .name = "dwhdmi-rockchip", > .of_match_table = dw_hdmi_rockchip_dt_ids, Using the power management operations (setting the .pm member in the embedded struct device_driver) is preferred over using the .resume and .suspend methods. Please update this patch to use the preferred method. Thanks. -- FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up according to speedtest.net. _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel