Re: [PATCH] drm/mm: Support 4 GiB and larger ranges

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jan 27, 2015 at 08:51:12AM +1000, Dave Airlie wrote:
> On 23 January 2015 at 18:05, Thierry Reding <thierry.reding@xxxxxxxxx> wrote:
> > From: Thierry Reding <treding@xxxxxxxxxx>
> >
> > The current implementation is limited by the number of addresses that
> > fit into an unsigned long. This causes problems on 32-bit Tegra where
> > unsigned long is 32-bit but drm_mm is used to manage an IOVA space of
> > 4 GiB. Given the 32-bit limitation, the range is limited to 4 GiB - 1
> > (or 4 GiB - 4 KiB for page granularity).
> >
> > This commit changes the start and size of the range to be an unsigned
> > 64-bit integer, thus allowing much larger ranges to be supported.
> 
> This seems fine to me, Chris, Daniel or Thomas, any objections?

None, lgtm. Would be worth just tidying the struct up for natural
alignment (especially the drm_mm_node) to remove some holes.

Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel





[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux