Hi Thierry,
Thank you for the patch.
On Friday 23 January 2015 17:08:20 Thierry Reding wrote:
> From: Thierry Reding <treding@xxxxxxxxxx>
>
> This brings xf86drmMode.h in sync with include/drm/drm_mode.h.
> Eventually we really should only have a single set of definitions rather
> than duplicating this in two files.
The purpose of these duplicate definitions is to avoid application build
breakages when compiled against an old drm.h header that doesn't include
drm_modes.h. Given that drm_modes.h has been introduced in 2.6.39 more than 6
years ago, wouldn't it be time to drop this ?
If we need to support old distributions (such as RHEL 5 for instance) shipping
kernel headers older than 2.6.39, do we still need to keep the definitions in
sync with newer kernel headers ? Build breakages would only occur when
compiling an application that makes use of the new definitions against old
kernel headers. If the distribution is stuck on <2.6.39 I doubt it will ship
applications using recent DRM features.
> Signed-off-by: Thierry Reding <treding@xxxxxxxxxx>
> ---
> xf86drmMode.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/xf86drmMode.h b/xf86drmMode.h
> index e70c16d437f4..70f14a1ae506 100644
> --- a/xf86drmMode.h
> +++ b/xf86drmMode.h
> @@ -130,6 +130,7 @@ extern "C" {
> #define DRM_MODE_ENCODER_TVDAC 4
> #define DRM_MODE_ENCODER_VIRTUAL 5
> #define DRM_MODE_ENCODER_DSI 6
> +#define DRM_MODE_ENCODER_DPMST 7
>
> #define DRM_MODE_SUBCONNECTOR_Automatic 0
> #define DRM_MODE_SUBCONNECTOR_Unknown 0
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel
