On Tue, Jan 20, 2015 at 08:16:25PM +0100, Jean-Francois Moine wrote: > To create simple cards, the syntax of the simple-card does not follow > the common binding of the device graphs > (Documentation/devicetree/bindings/graph.txt). Please be more specific, I really can't tell what this is supposed to be doing from the above - in what way is the binding not common and why would anyone care? Please also address why this is done as a completely separate implementation rather than a new revision of simple-card and CC Morimoto-san so he can review (given that he did simple-card initially). > sound/soc/generic/Kconfig | 2 + > sound/soc/generic/Makefile | 2 + > sound/soc/generic/dt-card.c | 275 ++++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 279 insertions(+) > create mode 100644 sound/soc/generic/dt-card.c As you know all device tree bindings require binding documents; you must supply a binding document. I'm not going to look at any DT patches that don't include binding documentation. In general please pay attention to changelogs and documentation when submitting patches, the harder it is to understand what a patch is supposed to do or why the harder it is to review. I keep saying this, it's really important.
Attachment:
signature.asc
Description: Digital signature
_______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
