On Tue, Jan 20, 2015 at 5:48 AM, Thierry Reding <thierry.reding@xxxxxxxxx> wrote: > From: Thierry Reding <treding@xxxxxxxxxx> > > There is no use-case where it would be useful for drivers not to > implement this function and the transitional plane helpers already > require drivers to provide an implementation. > > Signed-off-by: Thierry Reding <treding@xxxxxxxxxx> > --- > drivers/gpu/drm/drm_atomic_helper.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atomic_helper.c > index d467185f7942..010661f23035 100644 > --- a/drivers/gpu/drm/drm_atomic_helper.c > +++ b/drivers/gpu/drm/drm_atomic_helper.c > @@ -1108,7 +1108,7 @@ void drm_atomic_helper_commit_planes(struct drm_device *dev, > > funcs = plane->helper_private; > > - if (!funcs || !funcs->atomic_update) > + if (!funcs) maybe WARN_ON() here.. or drm_universal_plane_init(), or somewhere, for missing mandatory fxns would be a nice thing to avoid explosions under console_lock for first modeset? BR, -R > continue; > > old_plane_state = old_state->plane_states[i]; > -- > 2.1.3 > > _______________________________________________ > dri-devel mailing list > dri-devel@xxxxxxxxxxxxxxxxxxxxx > http://lists.freedesktop.org/mailman/listinfo/dri-devel _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
