On 2014년 12월 22일 22:04, Gustavo Padovan wrote: > Hi Dave, > > Here goes a bunch of clean up for the exynos driver. I've posted this work in > the mailing list twice but never got a review on it, first time was about a Never no. I already had a review and they - your first time patch set - had been merged to exynos-drm-next-todo. I was moving them to exynos-drm-next locally but one of your patch set was not reasonable to me so I gave you one comment. After that, you posted next patch set which include new changes and patches just 9 days ago. So they should also be reviewed enough at least for two weeks. Please, do not hurry. Such big changes should really be reviewed enough. I will wait for other reviews and them merge them if reviewed enough. If nobody have reviews then I will merge them. So please, don't worry about that. Thanks, Inki Dae > month ago. This work is the first building block for the atomic modesetting on > exynos. > > In the pull request we have: > > - removal of struct exynos_drm_overlay and struct exynos_drm_manager. > exynos_drm_overlay was merged with exynos_drm_plane and exynos_drm_manager > with exynos_drm_crtc removing two extra and unnecessary abstractions levels > from the exynos code. It also makes understanding of the code easier since > now we talk using known names like CRTC and Planes instead of manager and > overlay. > > - removal of DPMS operations from places where it is not need, e.g., updating > planes. > > - unification of plane update on exynos_update_plane(). Now all pieces of code > that wants to update a plane should be using this function. > > There are also some smalls fixes and clean ups. > > Gustavo > > --- > The following changes since commit 4e0cd68115620bc3236ff4e58e4c073948629b41: > > drm: sti: fix module compilation issue (2014-12-15 17:07:57 +1000) > > are available in the git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/padovan/drm-exynos-next.git master > > for you to fetch changes up to 31dd160f42138fff62a7c9ba71cd0f47b678fe4d: > > drm/exynos: create exynos_check_plane() (2014-12-19 15:41:05 -0200) > > ---------------------------------------------------------------- > Gustavo Padovan (21): > drm/exynos: move to_exynos_crtc() macro to main header > drm/exynos: expose struct exynos_drm_crtc > drm/exynos: remove exynos_drm_crtc_plane_* wrappers > drm/exynos: remove struct exynos_drm_overlay > drm/exynos/fimd: don't initialize 'ret' variable in fimd_probe() > drm/exynos/vidi: remove useless ops->commit() > drm/exynos: Don't touch DPMS when updating overlay planes > drm/exynos: don't do any DPMS operation while updating planes > drm/exynos: remove exynos_plane_commit() wrapper > drm/exynos: unify plane update on exynos_update_plane() > drm/exynos: call exynos_update_plane() directly on page flips > drm/exynos: remove exynos_drm_crtc_mode_set_commit() > drm/exynos: rename base object of struct exynos_drm_crtc to 'base' > drm/exynos: add pipe param to exynos_drm_crtc_create() > drm/exynos: remove pipe member of struct exynos_drm_manager > drm/exynos: move 'type' from manager to crtc struct > drm/exynos: remove drm_dev from struct exynos_drm_manager > drm/exynos: remove struct exynos_drm_manager > drm/exynos: don't duplicate drm_display_mode in fimd context > drm/exynos: remove mode_set() ops from exynos_crtc > drm/exynos: create exynos_check_plane() > > drivers/gpu/drm/exynos/exynos_drm_crtc.c | 185 +++++++++++++++++-------------------------------------- > drivers/gpu/drm/exynos/exynos_drm_crtc.h | 8 ++- > drivers/gpu/drm/exynos/exynos_drm_drv.h | 83 +++++++++++++++---------- > drivers/gpu/drm/exynos/exynos_drm_fimd.c | 181 +++++++++++++++++++++++++---------------------------- > drivers/gpu/drm/exynos/exynos_drm_plane.c | 138 +++++++++++++++++++++-------------------- > drivers/gpu/drm/exynos/exynos_drm_plane.h | 17 +++-- > drivers/gpu/drm/exynos/exynos_drm_vidi.c | 135 +++++++++++++++++----------------------- > drivers/gpu/drm/exynos/exynos_mixer.c | 159 +++++++++++++++++++++++------------------------ > 8 files changed, 412 insertions(+), 494 deletions(-) > _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
